Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use environment variable for argo cd user #12024

Merged
merged 1 commit into from
Jan 18, 2023
Merged

docs: use environment variable for argo cd user #12024

merged 1 commit into from
Jan 18, 2023

Conversation

rumstead
Copy link
Member

#10113 the Argo CD user ID is exposed as an environment variable. It is better to rely on that than hardcoding 999.

Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@rumstead
docs: use environment variable for argo cd user
d2fe891 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
jannfis
jannfis approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jannfis jannfis merged commit c9e4bcd into argoproj:master Jan 18, 2023
@rumstead rumstead deleted the patch-1 branch January 19, 2023 14:09
@rumstead
Copy link
Member Author

LGTM! Thanks!

Thanks for the review!

emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@rumstead @emirot
docs: use environment variable for argo cd user (argoproj#12024)
965e7a9 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@rumstead @schakrad
docs: use environment variable for argo cd user (argoproj#12024)
608b76a 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rumstead @jannfis