-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use period instead of parenthesis (#12042) #12044
docs: use period instead of parenthesis (#12042) #12044
Conversation
Hi @drozd-A, thanks for this PR. Can you please change the target branch to |
@jannfis This file and content aren't present as is on master |
Oops. That means they must have been removed (or moved to a different place). |
It's been moved to Can you please open an additional PR against that file in master, so we'll also cherry-pick into 2.6 (the next stable) |
@jannfis The changes in the PR are not present in master |
I see. Then this PR seems to be a duplicate of #11245. It was marked for cherry-picking into 2.5, but probably we forgot to cherry-pick it. |
598dae8
to
1e4c422
Compare
989bbd6
to
be0d6da
Compare
Codecov ReportBase: 47.38% // Head: 47.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12044 +/- ##
=======================================
Coverage 47.38% 47.38%
=======================================
Files 245 245
Lines 41670 41670
=======================================
Hits 19745 19745
Misses 19937 19937
Partials 1988 1988
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>
be0d6da
to
9514e16
Compare
@jannfis Found some other instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com> Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com> Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Closes #12042
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: