Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use period instead of parenthesis (#12042) #12044

Merged

Conversation

drozd-A
Copy link
Contributor

@drozd-A drozd-A commented Jan 19, 2023

Closes #12042

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jannfis
Copy link
Member

jannfis commented Jan 19, 2023

Hi @drozd-A, thanks for this PR. Can you please change the target branch to master instead? We'll cherry-pick from the default branch to release branches where required.

@drozd-A
Copy link
Contributor Author

drozd-A commented Jan 19, 2023

@jannfis This file and content aren't present as is on master

@jannfis
Copy link
Member

jannfis commented Jan 20, 2023

Oops. That means they must have been removed (or moved to a different place).

@jannfis
Copy link
Member

jannfis commented Jan 20, 2023

It's been moved to operator-manual by a change in #11888

Can you please open an additional PR against that file in master, so we'll also cherry-pick into 2.6 (the next stable)

@drozd-A
Copy link
Contributor Author

drozd-A commented Jan 20, 2023

@jannfis
Copy link
Member

jannfis commented Jan 20, 2023

I see.

Then this PR seems to be a duplicate of #11245. It was marked for cherry-picking into 2.5, but probably we forgot to cherry-pick it.

@drozd-A drozd-A changed the base branch from release-2.5 to master January 23, 2023 20:05
@drozd-A drozd-A force-pushed the docs-use-period-instead-of-parenthesis branch from 598dae8 to 1e4c422 Compare January 23, 2023 20:12
@drozd-A drozd-A changed the title Docs: use period instead of parenthesis (#12042) docs: use period instead of parenthesis (#12042) Jan 23, 2023
@drozd-A drozd-A force-pushed the docs-use-period-instead-of-parenthesis branch 4 times, most recently from 989bbd6 to be0d6da Compare January 23, 2023 20:30
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 47.38% // Head: 47.38% // No change to project coverage 👍

Coverage data is based on head (9514e16) compared to base (4a50114).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12044   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         245      245           
  Lines       41670    41670           
=======================================
  Hits        19745    19745           
  Misses      19937    19937           
  Partials     1988     1988           
Impacted Files Coverage Δ
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>
@drozd-A drozd-A force-pushed the docs-use-period-instead-of-parenthesis branch from be0d6da to 9514e16 Compare January 24, 2023 15:40
@drozd-A
Copy link
Contributor Author

drozd-A commented Jan 24, 2023

@jannfis Found some other instances of ) being used instead of .. I've updated the PR accordingly.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 221a039 into argoproj:master Jan 24, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>

Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>

Signed-off-by: Andriy Drozd <48000208+drozd-A@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix markdown for numbered lists
2 participants