fix: settings API should not fail if repo server is not available #12164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
I think this is a pretty bad bug that makes UI flaky. We should cherry-pick it to v2.6 . |
jessesuen
approved these changes
Jan 26, 2023
alexmt
added a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
The #11615 introduced a dependency on repo server in
GET /api/v1/system/settingsAPI. However we did not consider the fact thatGET /api/v1/system/settingsis critical for UI. So now UI is not functional if repo-server is temporary down.This PR is creates are separate API that exposes list of configured plugins and changes UI to use new API.