fix: surface source not permitted errors #12255

blakepettersson · 2023-02-02T11:48:45Z

For Git and Helm repositories, we filter out non-permitted urls before submitting a ManifestRequest to the repo-server. While that works fine, this also leads to very hard to debug issues in particular when using Helm dependencies.

This PR adds ProjectSourceRepos and ProjectName as parameters to ManifestRequest, so we can verify that a source is in fact permitted in order to distinguish between actual 40x errors (caused by e.g misconfiguration) and "source not permitted" errors caused by not adding the relevant sources to the AppProject config.

Signed-off-by: Blake Pettersson blake.pettersson@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

blakepettersson · 2023-02-02T11:54:31Z

~~Also, ATM I only added this bit when going through the Helm dependencies but we'd also need to add this for the Repos being passed in as well.~~ Done

codecov · 2023-02-07T09:19:37Z

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.04 ⚠️

Comparison is base (fa5ce09) 49.18% compared to head (6737a66) 49.15%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12255      +/-   ##
==========================================
- Coverage   49.18%   49.15%   -0.04%     
==========================================
  Files         248      248              
  Lines       42861    42914      +53     
==========================================
+ Hits        21083    21096      +13     
- Misses      19677    19712      +35     
- Partials     2101     2106       +5

Impacted Files	Coverage Δ
cmd/argocd/commands/app.go	`21.80% <0.00%> (-0.20%)`	⬇️
cmd/argocd/commands/project.go	`0.00% <0.00%> (ø)`
reposerver/repository/repository.go	`60.62% <23.07%> (-0.26%)`	⬇️
server/application/application.go	`49.58% <57.14%> (+0.05%)`	⬆️
controller/state.go	`67.98% <100.00%> (+0.10%)`	⬆️
util/argo/argo.go	`66.58% <100.00%> (+0.12%)`	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

reddy2018 · 2023-02-09T07:30:16Z

i am facing to add the OCI registry (docker hub) into the argocd.
i have created a secret to add the repository, but its failed state. here is my yaml file

apiVersion: v1
kind: Secret
metadata:
name: wrm6
namespace: argocd
labels:
argocd.argoproj.io/secret-type: repository
stringData:
enableOCI: "true"
type: helm
url: https://registry-1.docker.io/enghousenetworksbss/wrm

blakepettersson · 2023-02-09T08:39:16Z

@reddy2018 OK but your issue is not related to this PR. Please submit an issue in discussions or ask on the Argo Slack.

util/argo/argo.go

reposerver/repository/repository.go

blakepettersson · 2023-04-30T21:15:36Z

@ishitasequeira thanks for the review, I updated the PR with your suggestions!

ishitasequeira

Thanks @blakepettersson , I tested the feature and we can successfully see the source not permitted errors. I have some nits added. PTAL.

reposerver/repository/repository.go

test/e2e/helm_test.go

alexef

read through, didn't spot anything weird

ishitasequeira

Thanks @blakepettersson for addressing the comments. The changes look good. The CI seems to be failing, maybe worth re-triggering.

blakepettersson · 2023-05-10T07:37:56Z

Thanks @ishitasequeira! I tried to re-trigger the CI multiple times yesterday by rebasing on master, but it's failing on a bunch of unrelated things (e.g this one which would be "solved" by #13398).

For Git and Helm repositories, we filter out non-permitted urls before submitting a `ManifestRequest` to the repo-server. While that works fine, this also leads to very hard to debug issues in particular when using Helm dependencies. This (very) WIP PR adds `ProjectSourceRepos` as a parameter to `ManifestRequest`, so we can verify that a source is in fact permitted in order to distinguish between actual 40x errors (caused by e.g misconfiguration) and "source not permitted" caused by not adding the relevant sources to the AppProject config. This still needs documentation, tests and some basic sanity checking before proceeding further, as well as resolving whatever is causing `make codegen` to not properly work. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

now onto the e2e tests... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in argoproj#14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in argoproj#14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: surface source not permitted errors For Git and Helm repositories, we filter out non-permitted urls before submitting a `ManifestRequest` to the repo-server. While that works fine, this also leads to very hard to debug issues in particular when using Helm dependencies. This (very) WIP PR adds `ProjectSourceRepos` as a parameter to `ManifestRequest`, so we can verify that a source is in fact permitted in order to distinguish between actual 40x errors (caused by e.g misconfiguration) and "source not permitted" caused by not adding the relevant sources to the AppProject config. This still needs documentation, tests and some basic sanity checking before proceeding further, as well as resolving whatever is causing `make codegen` to not properly work. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: propagate project values to repo-server Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing unit tests now onto the e2e tests... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing e2e test(s) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: add project params Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add e2e test Add Helm dependency check test. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: remove git source check Discussed over Slack and deemed this to not be necessary at this time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: cr tweaks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: code review tweaks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: typo Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: typo Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: rebase fixes Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: oci:// is not prefixed Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Lev <lozeryan@akami.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Alexy Mantha <alexy@mantha.dev>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in argoproj#14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by…

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in argoproj#14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: lowercase URI secret name; abbreviated IPv6 address Signed-off-by: huyinhou <huyinhou@bytedance.com> --------- Signed-off-by: huyinhou <huyinhou@bytedance.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Enable haproxy metrics through helm Chart (#15459) Signed-off-by: Mathias Petermann <mathias.petermann@swisscom.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Stop appending :443 to the server address when using grpc-web (#15435) Signed-off-by: David Marby <david@dmarby.se> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: appset preserve labels and global preserve fields (#15445) * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425) * fix : don't create transport from scratch, clone it instead Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> * feat: clone http.transport for gitea and gitlab providers Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> * chore: properly format gitea providers with gofmt Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> --------- Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Factorial to USERS.md (#15473) Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix incorrect wording in Appli…

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by…

* chore: surface source not permitted errors For Git and Helm repositories, we filter out non-permitted urls before submitting a `ManifestRequest` to the repo-server. While that works fine, this also leads to very hard to debug issues in particular when using Helm dependencies. This (very) WIP PR adds `ProjectSourceRepos` as a parameter to `ManifestRequest`, so we can verify that a source is in fact permitted in order to distinguish between actual 40x errors (caused by e.g misconfiguration) and "source not permitted" caused by not adding the relevant sources to the AppProject config. This still needs documentation, tests and some basic sanity checking before proceeding further, as well as resolving whatever is causing `make codegen` to not properly work. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: propagate project values to repo-server Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing unit tests now onto the e2e tests... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing e2e test(s) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: add project params Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add e2e test Add Helm dependency check test. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: remove git source check Discussed over Slack and deemed this to not be necessary at this time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: cr tweaks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: code review tweaks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: typo Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: typo Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: rebase fixes Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: oci:// is not prefixed Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

This reverts commit c651bd8. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in argoproj#14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

) * fix: loosen source not permitted helm errors With argoproj#12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in argoproj#12555, otherwise we bubble up the error. Should fix argoproj#13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert argoproj#12255 (argoproj#14858)" This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by…

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: lowercase URI secret name; abbreviated IPv6 address Signed-off-by: huyinhou <huyinhou@bytedance.com> --------- Signed-off-by: huyinhou <huyinhou@bytedance.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Enable haproxy metrics through helm Chart (#15459) Signed-off-by: Mathias Petermann <mathias.petermann@swisscom.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Stop appending :443 to the server address when using grpc-web (#15435) Signed-off-by: David Marby <david@dmarby.se> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: appset preserve labels and global preserve fields (#15445) * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425) * fix : don't create transport from scratch, clone it instead Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> * feat: clone http.transport for gitea and gitlab providers Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> * chore: properly format gitea providers with gofmt Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> --------- Signed-off-by: Antoine Jouve <ant.jouve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Factorial to USERS.md (#15473) Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix incorrect wording in Appli…

* fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add missing value (#14538) Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page <dylan.page@autodesk.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <jonwest@redhat.com> * Respond to review comments Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis <kostis@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell <nateromriell@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <trung.hoang@pricehubble.com> * Use correct nil check Signed-off-by: Trung <trung.hoang@pricehubble.com> * Add missing catalog generation to makefile Signed-off-by: Trung <trung.hoang@pricehubble.com> * Revert changes to update-manifests.sh Signed-off-by: Trung <trung.hoang@pricehubble.com> --------- Signed-off-by: Trung <trung.hoang@pricehubble.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> --------- Signed-off-by: ashinsabu3 <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr <saschasynaos@gmail.com> * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr <saschasynaos@gmail.com> --------- Signed-off-by: xashr <saschasynaos@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich <german.lashevich@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * chore: wrap error objects to include context Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune <prune@lecentre.net> * Correct gitlab SCM provider mock test Signed-off-by: Prune <prune@lecentre.net> * updated test to validate shared-groups Signed-off-by: Prune <prune@lecentre.net> * reworked shared project tests Signed-off-by: Prune <prune@lecentre.net> * added subgroups only test Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb <vl.zemtsov@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue <yuezk001@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole <macole@beyondtrust.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S <vipinachar2016@gmail.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> --------- Signed-off-by: Ashin Sabu <ashin.sabu@harness.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: loosen string check Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys <pavel@codefresh.io> * update engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * update gitops engine version Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cli option Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: verify apply out of sync flag Signed-off-by: pashakostohrys <pavel@codefresh.io> * redundant comment Signed-off-by: pashakostohrys <pavel@codefresh.io> * improve test logic Signed-off-by: pashakostohrys <pavel@codefresh.io> * change command description and do codegen Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz <avhimazumder5@outlook.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore:changes in ulits.go Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> * chore: resolving utils_test.go file Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> --------- Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com> Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin <dylan@sla.vin> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> --------- Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: update confusing variable name (#15106) Signed-off-by: jmcshane <james.mcshane@superorbital.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune <prune@lecentre.net> * corrected few comments Signed-off-by: Prune <prune@lecentre.net> * removed latest tag references Signed-off-by: Prune <prune@lecentre.net> --------- Signed-off-by: Prune <prune@lecentre.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): code lint (#15150) Signed-off-by: ebuildy <ebuildy@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> --------- Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama <yudiandreanp@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro <carlos.castro@jumo.world> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli <pelenli@tencent.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti <prasad.katti@segment.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> --------- Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor <scott.windsor@flexe.com> * fix golang-cilint warning Signed-off-by: Scott Windsor <scott.windsor@flexe.com> --------- Signed-off-by: Scott Windsor <scott.windsor@flexe.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti <prasad.katti@segment.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain <mike.splain@gmail.com> * Update docs Signed-off-by: Mike Splain <mike.splain@gmail.com> --------- Signed-off-by: Mike Splain <mike.splain@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: add Dott to users (#15370) Signed-off-by: Jake Burn <jake@ridedott.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 <surya.asriadie@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West <brad.g.west@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * fix(15282) fix unit test Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: use untar with limiter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: failing unit test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> --------- Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Remove trailing newlines Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé <andreas@lindhe.io> * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé <andreas@lindhe.io> --------- Signed-off-by: Andreas Lindhé <andreas@lindhe.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu <ashupednekar49@gmail.com> * doc: re-generated cli docs Signed-off-by: ashu <ashupednekar49@gmail.com> --------- Signed-off-by: ashu <ashupednekar49@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis <jann@mistrust.net> * Only call ValidateDestination when allowed Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou <huyinhou@bytedance.com> * remove unused import Signed-off-by…

blakepettersson mentioned this pull request Feb 2, 2023

Repository credentials templates and Helm dependency #11717

Open

3 tasks

blakepettersson marked this pull request as ready for review February 8, 2023 18:10

blakepettersson requested review from alexef and crenshaw-dev February 8, 2023 18:11

crenshaw-dev changed the title ~~chore: surface source not permitted errors~~ fix: surface source not permitted errors Feb 8, 2023

blakepettersson force-pushed the chore/surface-source-not-permitted-errors-for-helm-repos branch from 59b03ba to 8e8a6cb Compare February 9, 2023 19:08

blakepettersson added this to the v2.7 milestone Feb 12, 2023

This was referenced Feb 16, 2023

Unhelpful "TypeError: Cannot read properties of undefined (reading 'chart')" error message when helm registry is not listed in sourceRepos #12487

Closed

Unable to use OCI Registry with sub helm charts #12436

Closed

blakepettersson force-pushed the chore/surface-source-not-permitted-errors-for-helm-repos branch from 8e8a6cb to f31ff99 Compare March 23, 2023 17:51

ishitasequeira reviewed Apr 29, 2023

View reviewed changes

util/argo/argo.go Outdated Show resolved Hide resolved

reposerver/repository/repository.go Outdated Show resolved Hide resolved

blakepettersson force-pushed the chore/surface-source-not-permitted-errors-for-helm-repos branch from f31ff99 to 3a85ea9 Compare April 30, 2023 20:00

ishitasequeira requested changes May 6, 2023

View reviewed changes

reposerver/repository/repository.go Outdated Show resolved Hide resolved

test/e2e/helm_test.go Show resolved Hide resolved

blakepettersson force-pushed the chore/surface-source-not-permitted-errors-for-helm-repos branch 3 times, most recently from b08162c to 746e476 Compare May 9, 2023 16:13

alexef approved these changes May 10, 2023

View reviewed changes

ishitasequeira approved these changes May 10, 2023

View reviewed changes

blakepettersson added the ready-for-review label May 10, 2023

blakepettersson force-pushed the chore/surface-source-not-permitted-errors-for-helm-repos branch from 746e476 to bf03cc1 Compare May 11, 2023 09:26

blakepettersson added 4 commits May 22, 2023 16:01

chore: propagate project values to repo-server

ae0c099

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

test: fix failing unit tests

f0c905a

now onto the e2e tests... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

test: fix failing e2e test(s)

01bb3ed

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

gcp-cherry-pick-bot bot mentioned this pull request Aug 2, 2023

chore: revert "fix: surface source not permitted errors (#12255)" (cherry-pick #14858) #14863

Merged

blakepettersson added a commit to blakepettersson/argo-cd that referenced this pull request Aug 9, 2023

Revert "chore: revert argoproj#12255 (argoproj#14858)"

f20fdda

This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

blakepettersson added a commit to blakepettersson/argo-cd that referenced this pull request Aug 12, 2023

Revert "chore: revert argoproj#12255 (argoproj#14858)"

a41aa76

This reverts commit c8ae5bc. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

suzaku mentioned this pull request Aug 15, 2023

use std lib suzaku/argo-cd#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: surface source not permitted errors #12255

fix: surface source not permitted errors #12255

blakepettersson commented Feb 2, 2023 •

edited

Loading

blakepettersson commented Feb 2, 2023 •

edited

Loading

codecov bot commented Feb 7, 2023 •

edited

Loading

reddy2018 commented Feb 9, 2023 •

edited

Loading

blakepettersson commented Feb 9, 2023

blakepettersson commented Apr 30, 2023

ishitasequeira left a comment

alexef left a comment

ishitasequeira left a comment

blakepettersson commented May 10, 2023

fix: surface source not permitted errors #12255

fix: surface source not permitted errors #12255

Conversation

blakepettersson commented Feb 2, 2023 • edited Loading

blakepettersson commented Feb 2, 2023 • edited Loading

codecov bot commented Feb 7, 2023 • edited Loading

Codecov Report

reddy2018 commented Feb 9, 2023 • edited Loading

blakepettersson commented Feb 9, 2023

blakepettersson commented Apr 30, 2023

ishitasequeira left a comment

Choose a reason for hiding this comment

alexef left a comment

Choose a reason for hiding this comment

ishitasequeira left a comment

Choose a reason for hiding this comment

blakepettersson commented May 10, 2023

blakepettersson commented Feb 2, 2023 •

edited

Loading

blakepettersson commented Feb 2, 2023 •

edited

Loading

codecov bot commented Feb 7, 2023 •

edited

Loading

reddy2018 commented Feb 9, 2023 •

edited

Loading