Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates from gometalinter to golangci-lint. Closes #1225 #1226

Merged
merged 9 commits into from
Mar 9, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 6, 2019

No description provided.

@alexec
Copy link
Contributor Author

alexec commented Mar 6, 2019

Build failed as it could not find the command. This is not a priority for me today.

@alexec
Copy link
Contributor Author

alexec commented Mar 6, 2019

Reduces make pre-commit from 2m to 1m

@alexec alexec closed this Mar 6, 2019
@alexec alexec reopened this Mar 6, 2019
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #1226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   37.22%   37.22%           
=======================================
  Files          59       59           
  Lines        8843     8843           
=======================================
  Hits         3292     3292           
  Misses       5052     5052           
  Partials      499      499
Impacted Files Coverage Δ
controller/cache/node.go 92.15% <ø> (ø) ⬆️
util/health/health.go 56.08% <ø> (ø) ⬆️
util/argo/audit_logger.go 0% <ø> (ø) ⬆️
util/oidc/oidc.go 3.2% <ø> (ø) ⬆️
controller/cache/info.go 35.82% <ø> (ø) ⬆️
util/db/db.go 70.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39174ab...81c7628. Read the comment docs.

@alexec alexec requested a review from alexmt March 7, 2019 02:25
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit 5e7b48c into argoproj:master Mar 9, 2019
@alexec alexec deleted the golangci-lint branch March 9, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants