Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provide example RBAC for API server in apps-in-any-namespace #12341

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Feb 8, 2023

The original PR for documenting apps in any namespace was missing the example RBAC mentioned in those docs.

This PR supplies the example RBAC for the Argo CD API server.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jannfis jannfis force-pushed the docs/apps-any-namespace-example-role branch from 1fb6f40 to 5bb5f51 Compare February 8, 2023 14:13
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (156dbd6) 47.78% compared to head (41422f6) 47.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12341   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files         246      246           
  Lines       42011    42011           
=======================================
  Hits        20073    20073           
  Misses      19937    19937           
  Partials     2001     2001           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jannfis jannfis enabled auto-merge (squash) March 11, 2023 14:28
@jannfis
Copy link
Member Author

jannfis commented Mar 11, 2023

/cherry-pick release-2.6

@jannfis jannfis merged commit 57544a6 into argoproj:master Mar 11, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 11, 2023
jannfis added a commit that referenced this pull request Mar 11, 2023
…12341) (#12824)

Signed-off-by: jannfis <jann@mistrust.net>
Co-authored-by: jannfis <jann@mistrust.net>
alexec pushed a commit to alexec/argo-cd that referenced this pull request Mar 19, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants