Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync dependencies (alpha). Fixes #3517 #12929

Closed
wants to merge 3 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 20, 2023

Depends on argoproj/gitops-engine#514.

Please see above PR for explanation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Fixes #3517

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title feat: Sync dependencies. Fixes #3517 feat: Sync dependencies (alpha). Fixes #3517 Mar 20, 2023
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (445de54) 47.97% compared to head (cef653f) 47.97%.

❗ Current head cef653f differs from pull request most recent head fefdef3. Consider uploading reports for the commit fefdef3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12929   +/-   ##
=======================================
  Coverage   47.97%   47.97%           
=======================================
  Files         246      246           
  Lines       42101    42101           
=======================================
  Hits        20197    20197           
  Misses      19890    19890           
  Partials     2014     2014           

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec closed this Mar 30, 2023
@bygui86
Copy link

bygui86 commented Mar 31, 2023

hi @alexec thanks a lot for working on this.
what's the status? closed means no merge?

@alexec
Copy link
Contributor Author

alexec commented Mar 31, 2023

I don’t have time availability to do this. Someone else must take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please allow for defining dependency DAG (Directed Acyclic Graph)
2 participants