fix: applicationset reduce redundant reconciles (#12457) (cherry-pick #12480) #13029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix: applicationset reduce redundant reconciles Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix: applicationset reduce redundant reconciles Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * adding tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * every line counts Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * deep copy applications from event object Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * update from code review Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * check progressive sync fields Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * check progressive sync fields Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * selective checks for progressive syncs Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * selective checks for progressive syncs Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * pural Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…oproj#12480) (argoproj#13029) * fix: applicationset reduce redundant reconciles * fix: applicationset reduce redundant reconciles * adding tests * every line counts * deep copy applications from event object * update from code review * check progressive sync fields * check progressive sync fields * selective checks for progressive syncs * selective checks for progressive syncs * pural --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: applicationset reduce redundant reconciles (#12457) (#12480)
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com