fix(manifests): use params CM and env var for redis server (#13214) #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13214) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13396 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 248 248
Lines 42891 42891
=======================================
Hits 21079 21079
Misses 19693 19693
Partials 2119 2119 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
commented
May 1, 2023
Comment on lines
-33
to
-35
| env: | ||
| - name: ARGOCD_REDIS_SERVICE | ||
| value: "" |
There was a problem hiding this comment.
I don't think this does anything. We're using the upstream redis image, which has no reason to know anything about an Argo CD env var.
crenshaw-dev
commented
May 1, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 2, 2023
…13396) * fix(manifests): use params CM and env var for redis server (#13214) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * add release note Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rephrase Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rephrase Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…13214) (argoproj#13396) (argoproj#13417) * fix(manifests): use params CM and env var for redis server (argoproj#13214) * add release note * rephrase * rephrase --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…13214) (argoproj#13396) * fix(manifests): use params CM and env var for redis server (argoproj#13214) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * add release note Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rephrase Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rephrase Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 9cb22d0
This pull request refactors the configuration of the Redis server address for Argo CD components by using a config map and an environment variable
ARGOCD_REDIS. This simplifies the installation and deployment of Argo CD in both standard and high availability modes. It also removes some redundant and hard-coded values from the manifests.Fixes #13214