chore: Print in-cluster svr addr disabled warning during ArgoDB initialization #14539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14539 +/- ##
==========================================
+ Coverage 49.79% 49.80% +0.01%
==========================================
Files 261 261
Lines 44751 44773 +22
==========================================
+ Hits 22283 22299 +16
- Misses 20274 20278 +4
- Partials 2194 2196 +2
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jul 17, 2023
|
@terrytangyuan is this enough of a problem that it should be cherry-picked? |
|
I think so but I'll leave that to @alexmt to confirm |
|
Api server liveness probe uses db.NewDB: https://github.com/argoproj/argo-cd/blob/master/server/server.go#L324C9-L324C9 so we still going to see this message a lot . @terrytangyuan can we make new function public and explicitly call it in main method on server start? |
|
@alexmt any opinion on whether we should cherry-pick this back to patch releases once we've got the final fix? |
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Jul 18, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
|
/cherry-pick release-2.8 |
|
Cherry-pick failed with |
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14683) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14684) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14685) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14686) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14520 (comment).