fix(appset): performProgressiveSyncs only when the applicationset is using it (#15297)

[ericblackburn]

Fixes #15297

Updates the if/else statement so that the else statement used to call performProgressiveSyncs is only called when the applicationset is using it.

Note, my build is green. There seems to be some other bugs in Argo ,master, itself unrelated to this change. Those are not in scope for the this PR.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dbc48f3) 49.67% compared to head (88c6a1e) 49.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #15299      +/-   ##
==========================================
- Coverage   49.67%   49.66%   -0.01%     
==========================================
  Files         267      267              
  Lines       46383    46385       +2     
==========================================
  Hits        23039    23039              
- Misses      21084    21086       +2     
  Partials     2260     2260              

Files	Coverage Δ
...cationset/controllers/applicationset_controller.go	60.39% <0.00%> (-0.11%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wmgroot]

This LGTM.

[blakepettersson]

Is there a way to do an E2E test to verify that the Application isn't jumping from Healthy -> Degraded -> Healthy with this change? Otherwise this LGTM

[ericblackburn]

Is there a way to do an E2E test to verify that the Application isn't jumping from Healthy -> Degraded -> Healthy with this change? Otherwise this LGTM

I tried to move all the content in this parent progressive sync is On block to its own function and write up unit tests, but I ran out of time. There are just no unit test for this area, so I would have to sit down and design that from scratch. Given my time limitations, I decided to just do the one line fix.

Eventually, I want to dedicate more time to bettering progressive sync functionality and add more unit testing. But, it would be a while until I can do that. I can push up a branch to my fork, if someone wants to take a look at my failed attempt at unit testing and tune it up.

[thober35]

Hi @blakepettersson,
any chance this could get approved and merged? Seeing a lot of performance impact regarding health status flapping.
Thank you!

[crenshaw-dev]

Thanks!

[crenshaw-dev]

/cherry-pick release-2.9

[crenshaw-dev]

/cherry-pick release-2.8

[crenshaw-dev]

/cherry-pick release-2.7

[crenshaw-dev]

/cherry-pick release-2.6

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 614a2531b0177b63d8887751fbe1f086dd416581 into temp-cherry-pick-06efef-release-2.6