fix(notifications-controller): Set cert resolver to use injected "argocd-tls-certs-cm"(#15392) #15394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15394 +/- ##
=======================================
Coverage 49.43% 49.43%
=======================================
Files 269 269
Lines 46790 46793 +3
=======================================
+ Hits 23131 23134 +3
Misses 21385 21385
Partials 2274 2274
☔ View full report in Codecov by Sentry. |
svghadi
force-pushed
the
notification-ca
branch
from
091eb73 to
ed5146e
Compare
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
svghadi
force-pushed
the
notification-ca
branch
from
c48ab45 to
59dcc3c
Compare
reginapizza
approved these changes
Oct 10, 2023
Signed-off-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
|
Thanks @ishitasequeira. Will this fix be backported to 2.9 & 2.8? |
|
/cherry-pick release-2.9 |
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
ishitasequeira
pushed a commit
that referenced
this pull request
Oct 31, 2023
ishitasequeira
pushed a commit
that referenced
this pull request
Oct 31, 2023
|
@svghadi , the change has been cherry-picked in 2.8 and 2.9 |
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15392
notifications-engineincludes functionality to use custom certs for notification services. However, in currentnotifications-controllercode we are missing the initialization of cert resolver function.Previously, when notification-controller was in a separate repo, the initialization of cert resolver was happening here.
This PR adds the missing initialization of cert resolver function in notifications-controller so that controller trusts custom certs for notification services.
I could not come up with a unit/e2e test because of dependency on external notification service with custom cert, but I validated the change local following the steps from linked issue and it worked as expected.
Checklist: