Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow retrieving badges in other namespaces (#15468) [release-2.8] #15482

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Sep 13, 2023

Cherry-pick of #15468 to release-2.8

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (7b89ae4) 49.95% compared to head (92a9833) 49.99%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #15482      +/-   ##
===============================================
+ Coverage        49.95%   49.99%   +0.04%     
===============================================
  Files              263      263              
  Lines            45061    45087      +26     
===============================================
+ Hits             22508    22541      +33     
+ Misses           20345    20339       -6     
+ Partials          2208     2207       -1     
Files Changed Coverage Δ
server/badge/badge.go 92.68% <100.00%> (+9.17%) ⬆️
server/server.go 55.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit 33fa128 into argoproj:release-2.8 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants