Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Added example usage for logout #15740

Closed
wants to merge 1 commit into from
Closed

chore(cli): Added example usage for logout #15740

wants to merge 1 commit into from

Conversation

gopikrishna7
Copy link

@gopikrishna7 gopikrishna7 commented Sep 30, 2023 •
edited by crenshaw-dev
Loading

For #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gopikrishna7 gopikrishna7 requested a review from a team as a code owner September 30, 2023 01:51
@gopikrishna7 gopikrishna7 changed the title CLI: Added example usage for logout #15690 cli: Added example usage for logout Sep 30, 2023
@gopikrishna7 gopikrishna7 changed the title cli: Added example usage for logout fix(cli): Added example usage for logout Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f25800) 49.98% compared to head (a0edf94) 49.92%.
Report is 16 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15740      +/-   ##
==========================================
- Coverage   49.98%   49.92%   -0.07%     
==========================================
  Files         266      266              
  Lines       46043    46069      +26     
==========================================
- Hits        23013    22998      -15     
- Misses      20772    20812      +40     
- Partials     2258     2259       +1
Files Coverage Δ
cmd/argocd/commands/logout.go 58.06% <100.00%> (+1.39%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev
crenshaw-dev requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gopikrishna7! Requested one small change. After making the change, could you run make clidocsgen? That will update the CLI reference to include your change.

@crenshaw-dev crenshaw-dev changed the title fix(cli): Added example usage for logout chore(cli): Added example usage for logout Oct 3, 2023
@crenshaw-dev
Copy link
Member

Looks like you also will have to run make lint-local

@gopikrishna7
added example usage for logout
a0edf94 
Signed-off-by: gopikrishna7 <gopikrishna.mgk7@gmail.com>
todaywasawesome
todaywasawesome reviewed Oct 5, 2023
View reviewed changes
docs/user-guide/commands/argocd_logout.md

```
# Logout from a context
argocd logout localhost:8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the example I would use something that looks explicitly like a context name. I don't know if you can logout by sever URL TBH.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can logout by server URL, I have tried and got the below response

argocd logout localhost:8080
Logged out from 'localhost:8080'

@crenshaw-dev
Copy link
Member

@gopikrishna7 another PR touched the same files. Can you rebase?

@crenshaw-dev
Copy link
Member

Looks like someone else got to this one first. Going with theirs since it has a bit more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

@todaywasawesome todaywasawesome Awaiting requested review from todaywasawesome

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gopikrishna7 @crenshaw-dev @todaywasawesome