Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adding logout examples #15834

Closed
wants to merge 9 commits into from

Conversation

gaurangkudale
Copy link
Contributor

@gaurangkudale gaurangkudale commented Oct 5, 2023

adding logout examples for improvment #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gaurangkudale gaurangkudale requested a review from a team as a code owner October 5, 2023 20:21
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a124588) 49.92% compared to head (fe201fa) 49.90%.
Report is 4 commits behind head on master.

❗ Current head fe201fa differs from pull request most recent head a498ffc. Consider uploading reports for the commit a498ffc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15834      +/-   ##
==========================================
- Coverage   49.92%   49.90%   -0.02%     
==========================================
  Files         266      266              
  Lines       46072    46089      +17     
==========================================
+ Hits        23001    23003       +2     
- Misses      20813    20828      +15     
  Partials     2258     2258              
Files Coverage Δ
cmd/argocd/commands/logout.go 58.06% <100.00%> (+1.39%) ⬆️
cmd/argocd/commands/relogin.go 19.11% <100.00%> (+1.20%) ⬆️
cmd/argocd/commands/completion.go 0.00% <0.00%> (ø)
cmd/argocd/commands/context.go 14.41% <0.00%> (-1.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev changed the title adding logout examples feat(cli): adding logout examples Oct 5, 2023
@crenshaw-dev
Copy link
Member

Thanks, @gaurangkudale! Could you run make lint and make clidocsgen?

@gaurangkudale
Copy link
Contributor Author

Hi @crenshaw-dev
After running make lint I am getting following error

INFO [runner] linters took 1m10.97599449s with stages: goanalysis_metalinter: 1m10.836537282s cmd/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/dev-mounter/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/gen-catalog/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/gen-crd-spec/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/gen-docs/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/gen-resources/cmd/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/k8s/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main hack/known_types/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main tools/cmd-docs/main.go:1: : error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. (typecheck) package main INFO File cache stats: 9 entries of total size 23.6KiB INFO Memory: 2127 samples, avg is 407.9MB, max is 2238.7MB INFO Execution took 3m36.491863015s make: *** [Makefile:355: lint-local] Error 1 make: *** [lint] Error 2

gaurangkudale and others added 9 commits October 6, 2023 12:30
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
* docs: fix list format (argoproj#15798)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* fix(appset): add option to disable SCM providers entirely (argoproj#14246) (argoproj#15248)

* feat(appset): add option to disable SCM providers entirely (argoproj#14246)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* clarify docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more clarification, small refactor

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more clarification

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* refactor

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix test assertion

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* simplify test expectation

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* add context example to help

Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* add context example to help Signed-off-by: sagarwala

Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* fea(cli)t: Add example to --help output for "argocd appset get" (argoproj#15808)

Signed-off-by: Michele Caci <michele.caci@gmail.com>
Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* fix: codeowners syntax error (argoproj#15781)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

* Trigger checks again Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: sagarwala1 <shailja_agarwala@intuit.com>
Signed-off-by: Michele Caci <michele.caci@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Co-authored-by: Michele Caci <michele.caci@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: jmcshane <james.mcshane@superorbital.io>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
* re-sign commit with DCO

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>

* Update doc file

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
…15662)

Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
* re-sign commit with DCO

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>

* Update doc file

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale gaurangkudale deleted the logout-example branch October 6, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants