Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adding logout examples #15841

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gaurangkudale
Copy link
Contributor

@gaurangkudale gaurangkudale commented Oct 6, 2023

adding logout examples for improvement #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gaurangkudale gaurangkudale requested a review from a team as a code owner October 6, 2023 07:17
@gaurangkudale gaurangkudale changed the title Update logout.go to add logout-examples feat(cli): adding logout examples #15834 Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.50%. Comparing base (f87897c) to head (be2d168).
Report is 13 commits behind head on master.

❗ Current head be2d168 differs from pull request most recent head e560db2. Consider uploading reports for the commit e560db2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15841      +/-   ##
==========================================
- Coverage   49.73%   49.50%   -0.23%     
==========================================
  Files         274      270       -4     
  Lines       48948    47495    -1453     
==========================================
- Hits        24343    23514     -829     
+ Misses      22230    21669     -561     
+ Partials     2375     2312      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaurangkudale
Copy link
Contributor Author

gaurangkudale commented Oct 6, 2023

If I ran make test then I am getting following error

`error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.

  • which go-junit-report
    /go/bin/go-junit-report
  • TEST_RESULTS=test-results
  • TEST_FLAGS=
  • test '' '!=' ''
  • test '' '!=' ''
  • mkdir -p test-results
  • GODEBUG=tarinsecurepath=0,zipinsecurepath=0
  • /go/src/github.com/argoproj/argo-cd/dist/gotestsum --rerun-fails-report=rerunreport.txt --junitfile=test-results/junit.xml --format=testname --rerun-fails=0 --packages= -- -coverprofile=coverage.out
    ./hack/test.sh: line 18: /go/src/github.com/argoproj/argo-cd/dist/gotestsum: No such file or directory
    make: *** [Makefile:388: test-local] Error 127
    make: *** [test] Error 2`

@gaurangkudale gaurangkudale changed the title feat(cli): adding logout examples #15834 feat(cli): adding logout examples Oct 6, 2023
@gaurangkudale gaurangkudale requested a review from a team as a code owner October 6, 2023 19:39
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like formatting is slightly off. Mind running make lint?

@gaurangkudale gaurangkudale force-pushed the logout-example branch 5 times, most recently from 8f9da9e to 7e44eeb Compare October 20, 2023 05:34
@gaurangkudale
Copy link
Contributor Author

Hi @crenshaw-dev
If you are free Can you please Review this PR?

@gaurangkudale gaurangkudale force-pushed the logout-example branch 2 times, most recently from ecd4597 to fc3c02e Compare October 25, 2023 16:18
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishitasequeira ishitasequeira enabled auto-merge (squash) October 25, 2023 20:30
auto-merge was automatically disabled October 26, 2023 04:48

Head branch was pushed to by a user without write access

@gaurangkudale gaurangkudale force-pushed the logout-example branch 4 times, most recently from f21c49a to 5e0ad54 Compare November 2, 2023 01:24
@ishitasequeira ishitasequeira enabled auto-merge (squash) November 2, 2023 01:27
auto-merge was automatically disabled November 2, 2023 02:17

Head branch was pushed to by a user without write access

@ishitasequeira ishitasequeira enabled auto-merge (squash) November 8, 2023 02:50
auto-merge was automatically disabled November 8, 2023 04:48

Head branch was pushed to by a user without write access

@ishitasequeira ishitasequeira enabled auto-merge (squash) November 15, 2023 22:10
auto-merge was automatically disabled December 15, 2023 19:21

Head branch was pushed to by a user without write access

@ishitasequeira ishitasequeira enabled auto-merge (squash) March 24, 2024 00:54
gaurangkudale and others added 6 commits March 24, 2024 11:40
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
…02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
auto-merge was automatically disabled March 24, 2024 06:10

Head branch was pushed to by a user without write access

@ishitasequeira ishitasequeira enabled auto-merge (squash) March 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants