Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add admin-app-example (#15690) #15861

Merged
merged 7 commits into from
Oct 25, 2023
Merged

feat(cli): add admin-app-example (#15690) #15861

merged 7 commits into from
Oct 25, 2023

Conversation

gaurangkudale
Copy link
Contributor

adding admin-app-example for improvement for #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gaurangkudale gaurangkudale requested review from a team as code owners October 7, 2023 07:44
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f37d24f) 49.54% compared to head (8d67b3f) 49.53%.
Report is 2 commits behind head on master.

❗ Current head 8d67b3f differs from pull request most recent head 6016832. Consider uploading reports for the commit 6016832 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15861      +/-   ##
==========================================
- Coverage   49.54%   49.53%   -0.01%     
==========================================
  Files         269      269              
  Lines       46641    46651      +10     
==========================================
+ Hits        23109    23110       +1     
- Misses      21259    21268       +9     
  Partials     2273     2273
Files Coverage Δ
cmd/argocd/commands/admin/app.go 30.03% <0.00%> (-1.00%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaurangkudale gaurangkudale force-pushed the admin-app-example branch 4 times, most recently from 762d38a to 6a548a0 Compare October 19, 2023 17:16
@gaurangkudale
Copy link
Contributor Author

Hi @blakepettersson
Can you please merge this PR if it looks good to you

@gaurangkudale
Copy link
Contributor Author

Hi @ashutosh16
I have updated the branch if it looks good to you Can you please merge it?

gaurangkudale and others added 7 commits October 25, 2023 21:48
@gaurangkudale
update the admin-app-example Signed-off-by: Author Name gaurang.kudal…
4e46040 
…e02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the admin-app-example Signed-off-by: Author Name gaurang.kudal…
7f47818 
…e02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the admin-app-example Signed-off-by: Author Name gaurang.kudal…
8971f21 
…e02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
updating the admin-app-example Signed-off-by: Author Name gaurang.kud…
b04b1e9 
…ale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
updating the admin-app-example Signed-off-by: Author Name gaurang.kud…
4f2a955 
…ale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale @blakepettersson
Update cmd/argocd/commands/admin/app.go
661bf52 
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
@gaurangkudale
update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com
6016832 
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
@ishitasequeira ishitasequeira merged commit 6e2f2c9 into argoproj:master Oct 25, 2023
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@gaurangkudale @blakepettersson @ymktmk
feat(cli): add admin-app-example (argoproj#15690) (argoproj#15861)
54b1397 
* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* Update cmd/argocd/commands/admin/app.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@gaurangkudale @blakepettersson @jmilic1
feat(cli): add admin-app-example (argoproj#15690) (argoproj#15861)
33245d0 
* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* Update cmd/argocd/commands/admin/app.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@gaurangkudale @blakepettersson @vladfr
feat(cli): add admin-app-example (argoproj#15690) (argoproj#15861)
4cfb451 
* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* Update cmd/argocd/commands/admin/app.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@gaurangkudale @blakepettersson @tesla59
feat(cli): add admin-app-example (argoproj#15690) (argoproj#15861)
903c6b7 
* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* Update cmd/argocd/commands/admin/app.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@gaurangkudale @blakepettersson @Hariharasuthan99
feat(cli): add admin-app-example (argoproj#15690) (argoproj#15861)
589bf35 
* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* updating the admin-app-example Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* Update cmd/argocd/commands/admin/app.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: Gaurang Kudale <gaurangkudale@yahoo.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

@ashutosh16 ashutosh16 ashutosh16 approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaurangkudale @blakepettersson @ashutosh16 @ishitasequeira @crenshaw-dev