Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add the repocred-list-example (#15690) #15869

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat(cli): add the repocred-list-example (#15690) #15869

merged 2 commits into from
Oct 18, 2023

Conversation

gaurangkudale
Copy link
Contributor

add the repocred-list-example (#15690)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@gaurangkudale gaurangkudale requested review from a team as code owners October 8, 2023 07:12
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (99a4bf0) 49.67% compared to head (d4366c9) 49.64%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15869      +/-   ##
==========================================
- Coverage   49.67%   49.64%   -0.03%     
==========================================
  Files         267      267              
  Lines       46383    46405      +22     
==========================================
+ Hits        23039    23040       +1     
- Misses      21084    21104      +20     
- Partials     2260     2261       +1
Files Coverage Δ
util/helm/cmd.go 35.21% <100.00%> (+1.14%) ⬆️
...cationset/controllers/applicationset_controller.go 60.39% <0.00%> (-0.11%) ⬇️
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
cmd/argocd/commands/repocreds.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira requested changes Oct 10, 2023
View reviewed changes
cmd/argocd/commands/repocreds.go Outdated
# List all the configured repository credentials in yaml format
argocd repocreds list -o yaml

# List all the configured repository credentials in url format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command prints the repository URLs and not the repository credentials in URL format. Change it to maybe:

List all repo urls or url patterns for repository credentials

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!
Changes are made as per your suggestions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests / Run unit tests with -race for Go packages (pull_request) This workflow is failing and the error says Received unexpected error: Token is expired
@ishitasequeira Do we need to rerun the workflow in this case?

@gaurangkudale
update the repocreds-list changes Signed-off-by: Author Name gaurang.…
8fca5f5 
…kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com
d4366c9 
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
ishitasequeira
ishitasequeira approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit f7a353a into argoproj:master Oct 18, 2023
@gaurangkudale gaurangkudale deleted the repocreds-examples branch October 22, 2023 05:25
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@gaurangkudale @ymktmk
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
09057bb 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@gaurangkudale @jmilic1
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
88c5a62 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@gaurangkudale @vladfr
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
fd73fe6 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@gaurangkudale @tesla59
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
306170a 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
@gaurangkudale @lukaszgyg
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
f3ff7b7 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@gaurangkudale @Hariharasuthan99
feat(cli): add the repocred-list-example (argoproj#15690) (argoproj#1…
8ee2078 
…5869)

* update the repocreds-list changes Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

* update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>

---------

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurangkudale @ishitasequeira @crenshaw-dev