Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Dark theme improvements #15891

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix(ui): Dark theme improvements #15891

merged 1 commit into from
Oct 24, 2023

Conversation

rpelczar
Copy link
Contributor

@rpelczar rpelczar commented Oct 11, 2023 •
edited
Loading

This PR is part of dark theme improvements along with argoproj/argo-ui#462

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@rpelczar rpelczar requested a review from a team as a code owner October 11, 2023 00:17
@rpelczar
fix(ui): Dark theme improvements
ff28909 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a124588) 49.92% compared to head (ff28909) 49.69%.
Report is 23 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15891      +/-   ##
==========================================
- Coverage   49.92%   49.69%   -0.24%     
==========================================
  Files         266      267       +1     
  Lines       46072    46362     +290     
==========================================
+ Hits        23001    23039      +38     
- Misses      20813    21063     +250     
- Partials     2258     2260       +2

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

terrytangyuan
terrytangyuan reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh16
Copy link
Contributor

@rpelczar The changes look good, however, could you please provide screenshots of the intended changes?

@rpelczar
Copy link
Contributor Author

rpelczar commented Oct 12, 2023 •
edited
Loading

@rpelczar The changes look good, however, could you please provide screenshots of the intended changes?

@ashutosh16 I've uploaded all screenshots to PR in argo-ui repo (I added info about that in the description), because most of the changes were there. I can upload the same screenshots here if you want.

@blakepettersson
Copy link
Member

@rpelczar that would be good, just so we can get an idea what is different here vs the PR in argo-ui

@rpelczar
Copy link
Contributor Author

@blakepettersson @ashutosh16 I added the screenshots.

alexmt
alexmt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for attaching screenshots!

@alexmt alexmt merged commit 91875c0 into argoproj:master Oct 24, 2023
24 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 24, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 24, 2023
@rpelczar
fix(ui): Dark theme improvements (#15891)
63af4e5 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
crenshaw-dev pushed a commit that referenced this pull request Oct 24, 2023
@gcp-cherry-pick-bot @rpelczar
fix(ui): Dark theme improvements (#15891) (#16096)
b14837e 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Co-authored-by: Rafal <rafpelczar@gmail.com>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@rpelczar @ymktmk
fix(ui): Dark theme improvements (argoproj#15891)
4eb1440 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@rpelczar @jmilic1
fix(ui): Dark theme improvements (argoproj#15891)
5dc66d4 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@rpelczar @vladfr
fix(ui): Dark theme improvements (argoproj#15891)
f8394c7 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@rpelczar @tesla59
fix(ui): Dark theme improvements (argoproj#15891)
cd1575e 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@rpelczar @Hariharasuthan99
fix(ui): Dark theme improvements (argoproj#15891)
6eeb8ca 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpelczar @ashutosh16 @blakepettersson @crenshaw-dev @alexmt @terrytangyuan