Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add timezone to projectwindows list #15929

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: Add timezone to projectwindows list #15929

merged 3 commits into from
Oct 25, 2023

Conversation

josephperez3
Copy link
Contributor

Added timezone to the default view of projectwindows list since it was missing.
Also added an example.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@josephperez3
list timezone in default list windows
bbdcaff 
Signed-off-by: Joseph Perez <perezj0230@gmail.com>
@josephperez3
add list example
f1553e7 
Signed-off-by: Joseph Perez <perezj0230@gmail.com>
@josephperez3
clidocsgen
4c464c9 
Signed-off-by: Joseph Perez <perezj0230@gmail.com>
@josephperez3 josephperez3 requested review from a team as code owners October 12, 2023 18:01
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f8f9ae9) 49.69% compared to head (4c464c9) 49.68%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15929      +/-   ##
==========================================
- Coverage   49.69%   49.68%   -0.01%     
==========================================
  Files         267      267              
  Lines       46362    46369       +7     
==========================================
  Hits        23039    23039              
- Misses      21063    21070       +7     
  Partials     2260     2260
Files Coverage Δ
cmd/argocd/commands/projectwindows.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephperez3 josephperez3 mentioned this pull request Oct 12, 2023
Open
13 tasks
blakepettersson
blakepettersson approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally LGTM 😄

ishitasequeira
ishitasequeira approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 591a94b into argoproj:master Oct 25, 2023
27 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@josephperez3 @ymktmk
fix: Add timezone to projectwindows list (argoproj#15929)
cbcb53b 
* list timezone in default list windows

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* add list example

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* clidocsgen

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

---------

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@josephperez3 @jmilic1
fix: Add timezone to projectwindows list (argoproj#15929)
7a9e067 
* list timezone in default list windows

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* add list example

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* clidocsgen

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

---------

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@josephperez3 @vladfr
fix: Add timezone to projectwindows list (argoproj#15929)
fee88f4 
* list timezone in default list windows

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* add list example

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* clidocsgen

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

---------

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@josephperez3 @tesla59
fix: Add timezone to projectwindows list (argoproj#15929)
8734110 
* list timezone in default list windows

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* add list example

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* clidocsgen

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

---------

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@josephperez3 @Hariharasuthan99
fix: Add timezone to projectwindows list (argoproj#15929)
4d3287b 
* list timezone in default list windows

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* add list example

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

* clidocsgen

Signed-off-by: Joseph Perez <perezj0230@gmail.com>

---------

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperez3 @blakepettersson @ishitasequeira