-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cmp): Document ConfigManagementPlugin.spec.version more clearly #15974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15974 +/- ##
==========================================
- Coverage 49.55% 49.43% -0.12%
==========================================
Files 269 269
Lines 46641 46790 +149
==========================================
+ Hits 23113 23131 +18
- Misses 21256 21385 +129
- Partials 2272 2274 +2 ☔ View full report in Codecov by Sentry. |
5f44ae9
to
97b4f6a
Compare
Rebased to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just a bit more explicit?
Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
97b4f6a
to
661e471
Compare
…rgoproj#15974) Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
…rgoproj#15974) Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
…rgoproj#15974) Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
…rgoproj#15974) Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
…rgoproj#15974) Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
Adds a description to the
spec.version
attribute in the CMP, to make it clearer that this is the version of the plugin, and is optional.This confused me quite a bit in the begining, and there were already tickets about this, eg. #13034
Checklist: