-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add examples to --help output for admin.go file #16030
Conversation
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16030 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 269 269
Lines 46892 46892
=======================================
Hits 23237 23237
Misses 21374 21374
Partials 2281 2281
☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add examples to admin.go Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> * Update argocd_admin.md Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
* add examples to admin.go Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> * Update argocd_admin.md Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
* add examples to admin.go Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> * Update argocd_admin.md Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
* add examples to admin.go Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> * Update argocd_admin.md Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
I am so confused by this PR... The examples advertise a bunch of commands that just don't exist. For example:
The command Similarly, there is no The same is true for many, many other examples added to I also cannot find any references to the mentioned commands inside the source code. I am using this version of the CLI, but as far as I can see, the commands mentioned in the examples of
Really, I would probably suggest to completely revert the whole PR. At least 90% of the added examples are bogus. I am new to ArgoCD and the example make it hard for me to learn the CLI. |
@ChristianCiach I'm guessing this was just ChatGPT garbage then. I'll clean it up. |
@akagami-harsh lmk if I'm wrong, but otherwise... yikes. |
@crenshaw-dev, omg i am so sorry 😔, i should have tested it before making a PR, deeply regret it now 😔. again i am so sowwy for the trouble i caused @ChristianCiach. I'm working on fixing the problem and will submit a follow-up PR as soon as possible. In the meantime, please let me know if there's anything I can do to help minimize any disruption this may have caused. |
@akagami-harsh no worries, we cleaned it up. If you'd like to submit a PR adding docs for |
* add examples to admin.go Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> * Update argocd_admin.md Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com> --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
--help
output #15690