fix: Use math.MaxInt (instead of math.MaxInt64) to fix builds on 32bit platforms #16065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16065 +/- ##
==========================================
+ Coverage 49.50% 49.52% +0.01%
==========================================
Files 269 269
Lines 47011 47011
==========================================
+ Hits 23274 23280 +6
+ Misses 21453 21447 -6
Partials 2284 2284
☔ View full report in Codecov by Sentry. |
ondrejsika
force-pushed
the
fix-builds-on-32bit-platforms
branch
2 times, most recently
from
36f9468 to
aadd94f
Compare
crenshaw-dev
approved these changes
Oct 23, 2023
|
Thanks, @ondrejsika! Can you fix the DCO check? |
|
There are other occurrences of |
ondrejsika
force-pushed
the
fix-builds-on-32bit-platforms
branch
2 times, most recently
from
9d81e3c to
840cfcd
Compare
|
@crenshaw-dev DCO is fixed, i've also rebased on the master, but there is something broken :( |
…t platforms Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>
ondrejsika
force-pushed
the
fix-builds-on-32bit-platforms
branch
from
840cfcd to
b0a51d3
Compare
|
@crenshaw-dev can u merge it, please? |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a fix of the wrong type