Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added example to admin-cluster.go and projectwindow.go files #16068

Closed
wants to merge 3 commits into from
Closed

feat: Added example to admin-cluster.go and projectwindow.go files #16068

wants to merge 3 commits into from

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Oct 23, 2023

part of the issue #15690
admin/Cluster.go file
admin/commnads/projectwindow.go file

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested review from a team as code owners October 23, 2023 09:01
retrigger 

Signed-off-by: Suraj yadav <harrypotter1108@gmail.com>
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (56a7bb7) 49.53% compared to head (774e6ce) 49.44%.

❗ Current head 774e6ce differs from pull request most recent head 06d1d87. Consider uploading reports for the commit 06d1d87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16068      +/-   ##
==========================================
- Coverage   49.53%   49.44%   -0.10%     
==========================================
  Files         269      269              
  Lines       46622    46703      +81     
==========================================
- Hits        23095    23091       -4     
- Misses      21255    21340      +85     
  Partials     2272     2272              
Files Coverage Δ
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)
cmd/argocd/commands/projectwindows.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant