Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add percona to list of Argo users #16079

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

edithturn
Copy link
Contributor

@edithturn edithturn commented Oct 23, 2023

Hi, Argo CD team!

I am adding Percona to the list of users.
cc @terrytangyuan

@edithturn edithturn requested review from a team as code owners October 23, 2023 15:51
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,7 +25,7 @@ Currently, the following organizations are **officially** using Argo CD:
1. [AppDirect](https://www.appdirect.com)
1. [Arctiq Inc.](https://www.arctiq.ca)
1. [ARZ Allgemeines Rechenzentrum GmbH](https://www.arz.at/)
2. [Autodesk](https://www.autodesk.com)
1. [Autodesk](https://www.autodesk.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. That is some else contribution. Maybe my mistake was not rebase it and I took that fix too

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a43b799) 49.55% compared to head (69ace30) 49.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16079      +/-   ##
==========================================
- Coverage   49.55%   49.54%   -0.01%     
==========================================
  Files         269      269              
  Lines       46641    46641              
==========================================
- Hits        23113    23110       -3     
- Misses      21256    21258       +2     
- Partials     2272     2273       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terrytangyuan
Copy link
Member

@edithturn You'll need to sign your commit to pass DCO check.

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edithturn
Copy link
Contributor Author

@edithturn You'll need to sign your commit to pass DCO check.

I just did a --amend -S, to sign my commit
I hope it works

USERS.md Outdated
@@ -321,3 +321,4 @@ Currently, the following organizations are **officially** using Argo CD:
1. [ZDF](https://www.zdf.de/)
1. [Zimpler](https://www.zimpler.com/)
1. [ZOZO](https://corp.zozo.com/)
1. [Percona](https://percona.com/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved up in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course :)
I am trying to signoff those as well., thank you!

@blakepettersson
Copy link
Member

@edithturn that didn't seem to work.. and now you have more commits so you'll need to signoff those as well

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS
@edithturn edithturn changed the title Add Percona user docs: add percona to list of Argo users Oct 24, 2023
@blakepettersson blakepettersson enabled auto-merge (squash) October 24, 2023 10:23
@edithturn
Copy link
Contributor Author

@edithturn that didn't seem to work.. and now you have more commits so you'll need to signoff those as well

Hi, @blakepettersson I think it is working now.
Appreciate your support.

@blakepettersson blakepettersson merged commit f8cd449 into argoproj:master Oct 24, 2023
22 of 23 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS

---------

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS

---------

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS

---------

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS

---------

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

* Add Percona user

Signed-off-by: Edith Puclla <edypuclla@gmail.com>

Add Percona in USERS

---------

Signed-off-by: Edith Puclla <edypuclla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants