-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): log button behaviors (#15848) #16098
Conversation
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16098 +/- ##
=======================================
Coverage 49.54% 49.55%
=======================================
Files 269 269
Lines 46641 46641
=======================================
+ Hits 23109 23113 +4
+ Misses 21259 21256 -3
+ Partials 2273 2272 -1 ☔ View full report in Codecov by Sentry. |
Good work - thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed locally that it works. Thanks so much @ciiay!!
/cherry-pick release-2.9 |
* Fixed log button behaviors Signed-off-by: Yi Cai <yicai@redhat.com> * Fixed lint-ui issues Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
* Fixed log button behaviors Signed-off-by: Yi Cai <yicai@redhat.com> * Fixed lint-ui issues Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
* Fixed log button behaviors Signed-off-by: Yi Cai <yicai@redhat.com> * Fixed lint-ui issues Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
* Fixed log button behaviors Signed-off-by: Yi Cai <yicai@redhat.com> * Fixed lint-ui issues Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
* Fixed log button behaviors Signed-off-by: Yi Cai <yicai@redhat.com> * Fixed lint-ui issues Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
signed-off by: @ciiay yicai@redhat.com
Closes issue #15848
🤖 Generated by Copilot at 84434ce
useRef
hook from React to create a reference to the logs container element (link)logsContainerRef
variable to store the reference (link)useEffect
hook to scroll the logs container element to the bottom ifscrollToBottom
state is true (link)handleScroll
function to handle the wheel event on the logs container element and setscrollToBottom
state to false if user scrolls up (link)logsContainerRef
to theref
prop andhandleScroll
to theonScroll
prop of the logs container element (link, link)onWheel
prop from the logs container element since it is redundant withonScroll
prop (link)Checklist:
Screenshot video
FixedLogButtons.mov