Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): log button behaviors (#15848) #16098

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Oct 24, 2023

signed-off by: @ciiay yicai@redhat.com

Closes issue #15848

🤖 Generated by Copilot at 84434ce

  • Import useRef hook from React to create a reference to the logs container element (link)
  • Declare logsContainerRef variable to store the reference (link)
  • Update useEffect hook to scroll the logs container element to the bottom if scrollToBottom state is true (link)
  • Define handleScroll function to handle the wheel event on the logs container element and set scrollToBottom state to false if user scrolls up (link)
  • Assign logsContainerRef to the ref prop and handleScroll to the onScroll prop of the logs container element (link, link)
  • Remove onWheel prop from the logs container element since it is redundant with onScroll prop (link)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Screenshot video

FixedLogButtons.mov

Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay requested a review from a team as a code owner October 24, 2023 20:38
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f37d24f) 49.54% compared to head (84434ce) 49.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16098   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files         269      269           
  Lines       46641    46641           
=======================================
+ Hits        23109    23113    +4     
+ Misses      21259    21256    -3     
+ Partials     2273     2272    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexec
Copy link
Contributor

alexec commented Oct 24, 2023

Good work - thank you!

@crenshaw-dev crenshaw-dev added this to the v2.9 milestone Oct 25, 2023
@crenshaw-dev crenshaw-dev changed the title fix: Fixed log button behaviors for issue #15848 fix(ui): log button behaviors (#15848) Oct 25, 2023
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally that it works. Thanks so much @ciiay!!

@crenshaw-dev crenshaw-dev merged commit 30e06d6 into argoproj:master Oct 25, 2023
28 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 25, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 25, 2023
* Fixed log button behaviors



* Fixed lint-ui issues



---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Co-authored-by: Yi Cai <yicai@redhat.com>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* Fixed log button behaviors

Signed-off-by: Yi Cai <yicai@redhat.com>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants