fix: upgrade notifications-engine #16120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
GilUpstream
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16120 +/- ##
==========================================
+ Coverage 49.51% 49.55% +0.04%
==========================================
Files 269 269
Lines 47011 47039 +28
==========================================
+ Hits 23277 23310 +33
+ Misses 21449 21443 -6
- Partials 2285 2286 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
Signed-off-by: Gilad Salmon <GilUpstream@users.noreply.github.com>
|
Hey @GilUpstream , could you please run |
@pasha-codefresh How long should that take to run? Toolchain guide mentions it may "take a while", but is that hours? |
|
@pasha-codefresh said about 30 min on MacOs |
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
…se Approver (argoproj#16341) Signed-off-by: Katie Lamkin <katie_lamkin@intuit.com> Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
…oproj#16342) Bumps [@types/superagent](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/superagent) from 4.1.15 to 4.1.21. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/superagent) --- updated-dependencies: - dependency-name: "@types/superagent" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
* docs: fix kustomize patches example Related to: argoproj#16352 Also, add an ApplicationSet example. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * fix: spelling Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
GilUpstream
force-pushed
the
upgrade-notifications-engine
branch
from
a7ff665 to
22df29e
Compare
|
replaced by #16354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade
notifications-engineto the latest version. One of the features added includes the new PR comment feature of thegithubservice.Fixes: argoproj/notifications-engine#211
Checklist: