Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): example for generate-allow-list #16136

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Conversation

range123
Copy link
Contributor

@range123 range123 commented Oct 27, 2023

Resolves one task in -> #15690

  1. Added an example in project_allowlist.go
  2. Relevant docs file is also updated

Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>
@range123
Copy link
Contributor Author

@crenshaw-dev

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4124adc) 49.43% compared to head (72873ed) 49.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16136      +/-   ##
==========================================
- Coverage   49.43%   49.42%   -0.01%     
==========================================
  Files         269      269              
  Lines       46788    46790       +2     
==========================================
  Hits        23128    23128              
- Misses      21385    21387       +2     
  Partials     2275     2275              
Files Coverage Δ
cmd/argocd/commands/admin/project_allowlist.go 31.48% <0.00%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
@crenshaw-dev crenshaw-dev merged commit 0cc0d46 into argoproj:master Oct 28, 2023
22 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Jayaraman N R <Jayaraman_NR@intuit.com>

Signed-off-by: Jayaraman N.R <adarsh1999@gmail.com>
Co-authored-by: Jayaraman N R <Jayaraman_NR@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants