Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application-controller): convert defaultDeploymentInformerResyncDuration to reflect 10 seconds #16163

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(application-controller): convert defaultDeploymentInformerResyncDuration to reflect 10 seconds #16163

merged 1 commit into from
Oct 30, 2023

Conversation

ishitasequeira
Copy link
Member

defaultDeploymentInformerResyncDuration gets interpreted as 10 nanoseconds, but I think it was meant to be seconds

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@ishitasequeira
convert defaultDeploymentInformerResyncDuration to reflect 10 seconds
3d7b941 
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@ishitasequeira ishitasequeira requested a review from a team as a code owner October 30, 2023 19:11
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 30, 2023 19:12
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d429013) 49.55% compared to head (3d7b941) 49.55%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16163   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       46852    46852           
=======================================
  Hits        23216    23216           
  Misses      21357    21357           
  Partials     2279     2279
Files Coverage Δ
controller/appcontroller.go 54.18% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit c47ea32 into argoproj:master Oct 30, 2023
21 of 22 checks passed
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 30, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@ishitasequeira
fix(application-controller): convert defaultDeploymentInformerResyncD…
0be2989 
…uration to reflect 10 seconds (#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira added a commit that referenced this pull request Oct 30, 2023
@gcp-cherry-pick-bot @ishitasequeira
fix(application-controller): convert defaultDeploymentInformerResyncD…
83ec3bf 
…uration to reflect 10 seconds (#16163) (#16167)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@ishitasequeira @jmilic1
fix(application-controller): convert defaultDeploymentInformerResyncD…
ad5881c 
…uration to reflect 10 seconds (argoproj#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@ishitasequeira @vladfr
fix(application-controller): convert defaultDeploymentInformerResyncD…
4ce5862 
…uration to reflect 10 seconds (argoproj#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@ishitasequeira @tesla59
fix(application-controller): convert defaultDeploymentInformerResyncD…
5317b45 
…uration to reflect 10 seconds (argoproj#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@ishitasequeira @lyda
fix(application-controller): convert defaultDeploymentInformerResyncD…
c82e775 
…uration to reflect 10 seconds (argoproj#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ishitasequeira @Hariharasuthan99
fix(application-controller): convert defaultDeploymentInformerResyncD…
81af163 
…uration to reflect 10 seconds (argoproj#16163)

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishitasequeira @crenshaw-dev