Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify namespace when restarting deployments in remote e2e tests #16192

Merged

Conversation

ChristopherFry
Copy link
Contributor

This pull request updates the end-to-end testing fixture to specify the namespace when restarting any of the Argo CD Server deployments for the remote tests. This allows any remote end-to-end tests pass that rely on restarting the Argo CD Servers. This includes any tests that adds SSH and TLS certificates.

Previously, the following error would be seen unless the namespace for the context in the kubeconfig was set to the Argo CD namespace:

time="2023-10-31T21:20:32Z" level=error msg="`kubectl rollout restart deployment argocd-server` failed exit status 1: Error from server (NotFound): deployments.apps \"argocd-server\" not found" execID=eb005

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Chris Fry <christopherfry@google.com>
@ChristopherFry ChristopherFry requested a review from a team as a code owner October 31, 2023 21:32
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d70f89) 49.55% compared to head (115fad2) 49.55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16192   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       46891    46891           
=======================================
+ Hits        23235    23236    +1     
+ Misses      21375    21374    -1     
  Partials     2281     2281           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 8e612b2 into argoproj:master Nov 1, 2023
27 checks passed
@ChristopherFry ChristopherFry deleted the cfry/restart-server-namespace branch November 1, 2023 15:40
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
…sts (argoproj#16192)

Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
…sts (argoproj#16192)

Signed-off-by: Chris Fry <christopherfry@google.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…sts (argoproj#16192)

Signed-off-by: Chris Fry <christopherfry@google.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
…sts (argoproj#16192)

Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…sts (argoproj#16192)

Signed-off-by: Chris Fry <christopherfry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants