-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: specify namespace when restarting deployments in remote e2e tests #16192
Merged
crenshaw-dev
merged 1 commit into
argoproj:master
from
ChristopherFry:cfry/restart-server-namespace
Nov 1, 2023
Merged
chore: specify namespace when restarting deployments in remote e2e tests #16192
crenshaw-dev
merged 1 commit into
argoproj:master
from
ChristopherFry:cfry/restart-server-namespace
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Fry <christopherfry@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16192 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 269 269
Lines 46891 46891
=======================================
+ Hits 23235 23236 +1
+ Misses 21375 21374 -1
Partials 2281 2281 ☔ View full report in Codecov by Sentry. |
blakepettersson
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crenshaw-dev
approved these changes
Nov 1, 2023
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…sts (argoproj#16192) Signed-off-by: Chris Fry <christopherfry@google.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…sts (argoproj#16192) Signed-off-by: Chris Fry <christopherfry@google.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…sts (argoproj#16192) Signed-off-by: Chris Fry <christopherfry@google.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…sts (argoproj#16192) Signed-off-by: Chris Fry <christopherfry@google.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…sts (argoproj#16192) Signed-off-by: Chris Fry <christopherfry@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the end-to-end testing fixture to specify the namespace when restarting any of the Argo CD Server deployments for the remote tests. This allows any remote end-to-end tests pass that rely on restarting the Argo CD Servers. This includes any tests that adds SSH and TLS certificates.
Previously, the following error would be seen unless the namespace for the context in the kubeconfig was set to the Argo CD namespace:
Checklist: