Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing lint and unit test #16275

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: failing lint and unit test #16275

merged 1 commit into from
Nov 8, 2023

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Nov 8, 2023 •
edited
Loading

closes #16278
relates to #15670

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@mikutas
fix: failing lint and unit test
16e7646 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas mikutas mentioned this pull request Nov 8, 2023
Merged
13 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58da6a3) 49.51% compared to head (16e7646) 49.52%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16275   +/-   ##
=======================================
  Coverage   49.51%   49.52%           
=======================================
  Files         269      269           
  Lines       46990    46990           
=======================================
+ Hits        23269    23272    +3     
+ Misses      21437    21435    -2     
+ Partials     2284     2283    -1

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikutas mikutas marked this pull request as ready for review November 8, 2023 05:13
@mikutas mikutas requested a review from a team as a code owner November 8, 2023 05:13
blakepettersson
blakepettersson approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙏 🙈

@blakepettersson
Copy link
Member

/cherry-pick release-2.8

@blakepettersson
Copy link
Member

/cherry-pick release-2.9

@blakepettersson blakepettersson mentioned this pull request Nov 8, 2023
Merged
13 tasks
@jdvgh jdvgh mentioned this pull request Nov 8, 2023
Merged
13 tasks
@matthewhughes-uw matthewhughes-uw mentioned this pull request Nov 8, 2023
Merged
13 tasks
@surajyadav1108 surajyadav1108 mentioned this pull request Nov 8, 2023
Merged
13 tasks
@blakepettersson blakepettersson merged commit 72245e8 into argoproj:master Nov 8, 2023
37 checks passed
@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 72245e8557b27bf2141fa5079c155f34a6d8c5ab into temp-cherry-pick-9f8386-release-2.8

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 72245e8557b27bf2141fa5079c155f34a6d8c5ab into temp-cherry-pick-9f8386-release-2.9

@mikutas mikutas deleted the fix-state-test branch November 8, 2023 12:28
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@mikutas @jmilic1
fix: failing lint and unit test (argoproj#16275)
4939977 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
@blakepettersson blakepettersson mentioned this pull request Nov 14, 2023
Merged
blakepettersson pushed a commit to blakepettersson/argo-cd that referenced this pull request Nov 14, 2023
@mikutas @blakepettersson
fix: failing lint and unit test (argoproj#16275)
7be093c 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@blakepettersson blakepettersson mentioned this pull request Nov 14, 2023
Closed
13 tasks
blakepettersson pushed a commit to blakepettersson/argo-cd that referenced this pull request Nov 14, 2023
@mikutas @blakepettersson
fix: failing lint and unit test (argoproj#16275)
a729563 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@mikutas @vladfr
fix: failing lint and unit test (argoproj#16275)
e44e06b 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@mikutas @tesla59
fix: failing lint and unit test (argoproj#16275)
6b6aaf7 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@mikutas @lyda
fix: failing lint and unit test (argoproj#16275)
34f5d63 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@mikutas @Hariharasuthan99
fix: failing lint and unit test (argoproj#16275)
1fdbc92 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint and unit test failure after #15670
3 participants
@mikutas @blakepettersson @ishitasequeira