-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initiated by in history and rollback view #16654
Conversation
469afe1
to
72f15a1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16654 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 271 271
Lines 47726 47728 +2
=======================================
+ Hits 23619 23620 +1
- Misses 21772 21773 +1
Partials 2335 2335 ☔ View full report in Codecov by Sentry. |
...pp/applications/components/application-deployment-history/application-deployment-history.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @robinlieb for working on this!
Will wait for @keithchong to conclude the UI review before merging.
...pp/applications/components/application-deployment-history/application-deployment-history.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leoluz , LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robinlieb There is one last request in this PR. As you are changing the Application CRD, this needs to be stated in the "upgrading" doc.
As we just cut the 2.10 branch a few days ago, the file is not created yet. It needs to be created in:
/docs/operator-manual/upgrading/2.10-2.11.md
and linked here:
Line 131 in 7847e7f
- operator-manual/upgrading/2.9-2.10.md |
See this doc as an example:
https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/1.6-1.7/#appproject-tokens-moved-to-status-field
72f15a1
to
49bbf74
Compare
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
49bbf74
to
d15baaa
Compare
@leoluz thanks for the hint! Added the respective upgrading doc and linked it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thank you!
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: hbc <bcxxxxxx@gmail.com>
Signed-off-by: ggkhrmv <gg.khrmv@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: penglongli <pelenli@tencent.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Edit: This is working for the Sync Status view, but always shows as Unknown on the History and Rollback view, even for the latest record. v2.11.5+c4b283c |
Same for me with release - v2.11.7+e4a0246 - All actions appears as user "unknown" for field "Initiated By" |
Closes #16612
As mentioned in the issue this PR adds Initiated by in the history and rollback view.
Checklist: