docs: configmap items are strings #16737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.10 |
blakepettersson
approved these changes
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16737 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 271 271
Lines 47728 47728
=======================================
Hits 23620 23620
Misses 21773 21773
Partials 2335 2335 ☔ View full report in Codecov by Sentry. |
34fathombelow
approved these changes
Jan 3, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 3, 2024
sonamkshenoy
pushed a commit
to sonamkshenoy/argo-cd
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
bcho
pushed a commit
to bcho/argo-cd
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: hbc <bcxxxxxx@gmail.com>
ebuildy
pushed a commit
to ebuildy/argo-cd
that referenced
this pull request
Jan 7, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: ebuildy <ebuildy@gmail.com>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
penglongli
pushed a commit
to penglongli/argo-cd
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: penglongli <pelenli@tencent.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docs show an invalid example. Items under
datamust be strings, never booleans.