Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update users.md with IllumiDesk #16742

Merged
merged 1 commit into from
Jan 4, 2024
Merged

docs: update users.md with IllumiDesk #16742

merged 1 commit into from
Jan 4, 2024

Conversation

jgwerner
Copy link
Contributor

@jgwerner jgwerner commented Jan 4, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).
  • Optional. My organization is added to USERS.md.

N/A

  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Greg Werner <werner.greg@gmail.com>
@jgwerner jgwerner requested review from a team as code owners January 4, 2024 03:55
@jgwerner jgwerner changed the title Update USERS.md with IllumiDesk docs: update users.md with IllumiDesk Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1975074) 49.48% compared to head (daaa133) 49.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16742   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         271      271           
  Lines       47728    47728           
=======================================
  Hits        23620    23620           
  Misses      21773    21773           
  Partials     2335     2335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gdsoumya gdsoumya merged commit d595550 into argoproj:master Jan 4, 2024
35 of 36 checks passed
bcho pushed a commit to bcho/argo-cd that referenced this pull request Jan 4, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: hbc <bcxxxxxx@gmail.com>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this pull request Jan 7, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: ebuildy <ebuildy@gmail.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
clement-heetch pushed a commit to clement-heetch/argo-cd that referenced this pull request Feb 12, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants