Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation around repo connections #1709

Merged
merged 4 commits into from
Jun 7, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 7, 2019

No description provided.

@alexec alexec requested review from alexmt and jessesuen June 7, 2019 00:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1709 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1709      +/-   ##
=========================================
- Coverage   33.98%   33.9%   -0.08%     
=========================================
  Files          75      75              
  Lines       11344   11344              
=========================================
- Hits         3855    3846       -9     
- Misses       6957    6970      +13     
+ Partials      532     528       -4
Impacted Files Coverage Δ
controller/appcontroller.go 38.62% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdabd5b...61fbcc6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1709 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1709      +/-   ##
=========================================
+ Coverage   33.98%     34%   +0.02%     
=========================================
  Files          75      75              
  Lines       11344   11344              
=========================================
+ Hits         3855    3858       +3     
+ Misses       6957    6954       -3     
  Partials      532     532
Impacted Files Coverage Δ
server/server.go 46.74% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdabd5b...8bff2fe. Read the comment docs.

docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
docs/user-guide/private-repositories.md Show resolved Hide resolved
docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
docs/user-guide/private-repositories.md Outdated Show resolved Hide resolved
alexec added 2 commits June 7, 2019 08:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alexec alexec requested a review from jessesuen June 7, 2019 15:45
@alexec alexec dismissed jessesuen’s stale review June 7, 2019 23:21

made changes

@alexec alexec added this to the v1.1 milestone Jun 7, 2019
@alexec alexec merged commit 6049545 into argoproj:master Jun 7, 2019
@alexec alexec deleted the doc-repo-connection branch June 7, 2019 23:21
@KarstenSiemer
Copy link
Contributor

would be great to always include information about how to configure the stuff via configmaps/secrets in addition to ui/cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants