Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1693 - Project Editor: Whitelisted Cluster Resources doesn't s… #1722

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Issue #1693 - Project Editor: Whitelisted Cluster Resources doesn't s… #1722

merged 1 commit into from
Jun 10, 2019

Conversation

AdityaGupta1
Copy link
Contributor

…trip whitespace

Closes #1693

Trims whitespace around whitelisted cluster resources before saving them

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #1722 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
- Coverage   34.17%   34.14%   -0.03%     
==========================================
  Files          77       77              
  Lines       11433    11433              
==========================================
- Hits         3907     3904       -3     
- Misses       6985     6988       +3     
  Partials      541      541
Impacted Files Coverage Δ
server/server.go 46.27% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f14f75...839e9db. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #1722 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
- Coverage   34.17%   34.14%   -0.03%     
==========================================
  Files          77       77              
  Lines       11433    11433              
==========================================
- Hits         3907     3904       -3     
- Misses       6985     6988       +3     
  Partials      541      541
Impacted Files Coverage Δ
server/server.go 46.27% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f14f75...839e9db. Read the comment docs.

@alexec alexec added this to the v1.1 milestone Jun 10, 2019
@alexec alexec merged commit 4dc102a into argoproj:master Jun 10, 2019
@AdityaGupta1 AdityaGupta1 deleted the trim-whitespace branch June 10, 2019 18:56
@stgarf
Copy link
Contributor

stgarf commented Jun 10, 2019

@AdityaGupta1 nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Editor: Whitelisted Cluster Resources doesn't strip whitespace
3 participants