Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Timestamp for Health Status (#16972) #17263

Closed
wants to merge 5 commits into from
Closed

feat: Timestamp for Health Status (#16972) #17263

wants to merge 5 commits into from

Conversation

mkieweg
Copy link
Contributor

@mkieweg mkieweg commented Feb 21, 2024

This PR contains an implementation of the enhancement proposal #16972
Closes [16972]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

First draft
92b2d5f 
Signed-off-by: Manuel Kieweg <mkieweg@vectra.ai>
@mkieweg mkieweg force-pushed the health-status-timestamp branch from 5e081ac to 92b2d5f Compare February 21, 2024 12:59
Manuel Kieweg and others added 4 commits February 21, 2024 17:57
@svghadi
Copy link
Contributor

svghadi commented May 6, 2024

Hi @mkieweg, thanks for the PR. Is it ready for review?

Additionally, I was thinking would it might make sense to change the new field name from timestamp to lastTransitionTime to align with naming convention. I've noticed that both Applications and Applicationsets use lastTransitionTime in their status. What are your thoughts on this?

@mkieweg
Copy link
Contributor Author

mkieweg commented May 6, 2024

Hey @svghadi, I was running into some issues with setting up the test dev environment locally and then had to pause the work due to shifting priorities. I'm planning to revise the current state and get my working branch on par with main this week.

Changing the name to adhere to existing conventions sounds like a good idea to me.

@mkieweg
Copy link
Contributor Author

mkieweg commented Jun 14, 2024

Closed in favour of #18660

@mkieweg mkieweg closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkieweg @svghadi @blakepettersson