Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reposerver): fix OCI repository matching (#12436) #17955

Merged
merged 2 commits into from
May 17, 2024

Conversation

MioOgbeni
Copy link
Contributor

@MioOgbeni MioOgbeni commented Apr 24, 2024

When an OCI repository is used as a Helm Chart dependency, there must not be an exact match for the dependency URL and the repo URL. This PR fixes usage for OCI registry located deeper in the registry structure.

I also created a unit test for this case

Fixes #12436

This issue is also in older version v2.10.7, it would be great if the PR was cherry-picked into the v2.10.x patch.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

MioOgbeni and others added 2 commits April 24, 2024 13:54
@MioOgbeni MioOgbeni marked this pull request as ready for review April 24, 2024 14:30
@MioOgbeni MioOgbeni requested review from a team as code owners April 24, 2024 14:30
@LordGaav
Copy link

Any progress on this? The code change looks simple enough, and without this OCI Helm charts that require credentials are not really usable.

@MioOgbeni
Copy link
Contributor Author

Still without review :/ It's really simple fix, can someone look at this?

@pasha-codefresh pasha-codefresh self-requested a review May 17, 2024 15:35
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this

@pasha-codefresh pasha-codefresh merged commit 210f26a into argoproj:master May 17, 2024
29 of 31 checks passed
rumstead pushed a commit to rumstead/argo-cd that referenced this pull request Jun 6, 2024
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
@DjinNO
Copy link

DjinNO commented Aug 9, 2024

Hello, I am using ArgoCD version v2.12.0+ec30a48. The deployment goes through, but ArgoCD still shows an error:

ComparisonError: Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = Manifest generation error (cached): helm dependency build failed exit status 1: Error: could not download oci://ghcr.io/example/app-values/base: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Aexample%2Fapp-values%2Fbase%3Apull&service=ghcr.io: 403 Forbidden

@PhamQuang-512
Copy link

PhamQuang-512 commented Aug 15, 2024

i'm getting same issue in version v2.11.7 and v2.12.0

Hello, I am using ArgoCD version v2.12.0+ec30a48. The deployment goes through, but ArgoCD still shows an error:

ComparisonError: Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = Manifest generation error (cached): helm dependency build failed exit status 1: Error: could not download oci://ghcr.io/example/app-values/base: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Aexample%2Fapp-values%2Fbase%3Apull&service=ghcr.io: 403 Forbidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use OCI Registry with sub helm charts
5 participants