-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reposerver): fix OCI repository matching (#12436) #17955
Conversation
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Any progress on this? The code change looks simple enough, and without this OCI Helm charts that require credentials are not really usable. |
Still without review :/ It's really simple fix, can someone look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing this
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Hello, I am using ArgoCD version v2.12.0+ec30a48. The deployment goes through, but ArgoCD still shows an error:
|
i'm getting same issue in version v2.11.7 and v2.12.0
|
When an OCI repository is used as a Helm Chart dependency, there must not be an exact match for the dependency URL and the repo URL. This PR fixes usage for OCI registry located deeper in the registry structure.
I also created a unit test for this case
Fixes #12436
This issue is also in older version v2.10.7, it would be great if the PR was cherry-picked into the v2.10.x patch.
Checklist: