fix: concurrent SlugifyName access (#18369)

USERS.md

@@ -324,6 +324,7 @@ Currently, the following organizations are **officially** using Argo CD:
 1. [UFirstGroup](https://www.ufirstgroup.com/en/)
 1. [ungleich.ch](https://ungleich.ch/)
 1. [Unifonic Inc](https://www.unifonic.com/)
+1. [Union Inc](https://www.union.ai/)
 1. [Universidad Mesoamericana](https://www.umes.edu.gt/)
 1. [Upsider Inc.](https://up-sider.com/lp/)
 1. [Urbantz](https://urbantz.com/)

applicationset/utils/utils.go

@@ -12,6 +12,7 @@ import (
 	"regexp"
 	"sort"
 	"strings"
+	"sync"
 	"text/template"
 	"unsafe"
 
@@ -26,6 +27,7 @@ import (
 )
 
 var sprigFuncMap = sprig.GenericFuncMap() // a singleton for better performance
+var slugifyNameMutex sync.Mutex
 
 func init() {
 	// Avoid allowing the user to learn things about the environment.
@@ -454,6 +456,10 @@ func NormalizeBitbucketBasePath(basePath string) string {
 // Returns:
 // - string: The generated URL-friendly slug based on the input name and options.
 func SlugifyName(args ...interface{}) string {
+	// Necessary mutex due to global shared state.
+	// https://github.com/argoproj/argo-cd/issues/18369
+	slugifyNameMutex.Lock()
+	defer slugifyNameMutex.Unlock()
 	// Default values for arguments
 	maxSize := 50
 	EnableSmartTruncate := true

applicationset/utils/utils_test.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"os"
 	"path"
+	"sync"
 	"testing"
 	"time"
 
@@ -1278,6 +1279,28 @@ func TestSlugify(t *testing.T) {
 		result := SlugifyName(c.length, c.smartTruncate, c.branch)
 		assert.Equal(t, c.expectedBasePath, result, c.branch)
 	}
+
+	t.Run("Managed concurrent access", func(t *testing.T) {
+		const numberOfRoutines = 2
+
+		for x := 0; x < 100; x++ {
+			var wg sync.WaitGroup
+			wg.Add(numberOfRoutines)
+			for i := 0; i < numberOfRoutines; i++ {
+				go func(length int) {
+					defer wg.Done()
+					// Call the function concurrently
+					result := SlugifyName(length, false, "test")
+					if length == 1 {
+						assert.Equal(t, "t", result)
+					} else {
+						assert.Equal(t, "te", result)
+					}
+				}(i + 1)
+			}
+			wg.Wait()
+		}
+	})
 }
 
 func TestGetTLSConfig(t *testing.T) {