-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): allow validation of fine-grained policy in project #19338
fix(rbac): allow validation of fine-grained policy in project #19338
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19338 +/- ##
==========================================
- Coverage 52.80% 52.78% -0.02%
==========================================
Files 316 316
Lines 43587 43587
==========================================
- Hits 23014 23008 -6
Misses 18024 18024
- Partials 2549 2555 +6 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-2.12 |
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
… (#19339) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…roj#19338) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>
The support for fine-grained policies for update and delete was added with #18124, but it was impossible to configure the project via UI/API to configure these policies.