Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datasource in dashboard.json #19426

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: datasource in dashboard.json #19426

merged 1 commit into from
Aug 9, 2024

Conversation

Rohlik
Copy link
Contributor

@Rohlik Rohlik commented Aug 7, 2024 •
edited
Loading

Other panels have properly set "uid": "$datasource", but for some reason, this doesn't. Let's fix it.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Rohlik Rohlik requested a review from a team as a code owner August 7, 2024 13:10
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 7, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 7, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Rohlik
fix: datasource in dashboard.json
9989131 
Other panels have properly set `"uid": "$datasource"`, but for some reason, this doesn't.
Let's fix it.

Signed-off-by: TomasR <linux@rohlik.xyz>
@Rohlik Rohlik changed the title Fix datasource in dashboard.json fix: datasource in dashboard.json Aug 7, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (21ed19b) to head (9989131).
Report is 512 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19426   +/-   ##
=======================================
  Coverage   52.83%   52.83%           
=======================================
  Files         316      316           
  Lines       43653    43656    +3     
=======================================
+ Hits        23064    23067    +3     
  Misses      18033    18033           
  Partials     2556     2556

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rohlik
Copy link
Contributor Author

Rohlik commented Aug 9, 2024

Can someone tell me what is wrong with "License Compliance"?

gdsoumya
gdsoumya approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdsoumya gdsoumya merged commit 992716b into argoproj:master Aug 9, 2024
29 of 31 checks passed
ilia-medvedev-codefresh pushed a commit to ilia-medvedev-codefresh/argo-cd that referenced this pull request Aug 13, 2024
@Rohlik @ilia-medvedev-codefresh
fix: datasource in dashboard.json (argoproj#19426)
7c9c5b1 
Other panels have properly set `"uid": "$datasource"`, but for some reason, this doesn't.
Let's fix it.

Signed-off-by: TomasR <linux@rohlik.xyz>
Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
reggie-k pushed a commit to reggie-k/argo-cd that referenced this pull request Aug 14, 2024
@Rohlik @reggie-k
fix: datasource in dashboard.json (argoproj#19426)
750f311 
Other panels have properly set `"uid": "$datasource"`, but for some reason, this doesn't.
Let's fix it.

Signed-off-by: TomasR <linux@rohlik.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohlik @gdsoumya