Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change the dark mode of the values files in the helm tab ui(#19394) #19482

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: Change the dark mode of the values files in the helm tab ui(#19394) #19482

merged 1 commit into from
Aug 15, 2024

Conversation

thisishwan2
Copy link
Contributor

Hello. This is a PR for issue #19394
I solved the problem of poor visibility of the values files when the user chooses the file on the helm tab in dark mode.

before

after

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thisishwan2 thisishwan2 requested a review from a team as a code owner August 11, 2024 13:46
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@thisishwan2 thisishwan2 changed the title modify ui in dark mode in source selection tag fix: Change the dark mode of the values files in the helm tab ui(#19394) Aug 11, 2024
todaywasawesome
todaywasawesome approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisishwan2
modify ui in dark mode in source selection tag
540df7f 
Signed-off-by: thisishwan2 <feel000617@gmail.com>
@pasha-codefresh pasha-codefresh merged commit afc2fe7 into argoproj:master Aug 15, 2024
24 of 25 checks passed
ChichiCaleb pushed a commit to ChichiCaleb/argo-cd that referenced this pull request Aug 15, 2024
@thisishwan2
modify ui in dark mode in source selection tag (argoproj#19482)
96e9ee2 
Signed-off-by: thisishwan2 <feel000617@gmail.com>
Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com>
ChichiCaleb pushed a commit to ChichiCaleb/argo-cd that referenced this pull request Aug 15, 2024
@thisishwan2 @ChichiCaleb
modify ui in dark mode in source selection tag (argoproj#19482)
a7c23c9 
Signed-off-by: thisishwan2 <feel000617@gmail.com>
Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisishwan2 @todaywasawesome @pasha-codefresh