Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache helm-index in Redis cluster (#12314) #19530

Merged
merged 4 commits into from
Aug 21, 2024
Merged

fix: cache helm-index in Redis cluster (#12314) #19530

merged 4 commits into from
Aug 21, 2024

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Aug 14, 2024

Fixes #12314 that use the Redis cluster as the helm index.yaml cache as well.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jenting jenting requested a review from a team as a code owner August 14, 2024 12:29
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 14, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 14, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@jenting jenting force-pushed the fix-helm-index-cache branch from a26c2eb to eabd5c2 Compare August 14, 2024 12:31
todaywasawesome
todaywasawesome reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some testing but looks good. I'll try to run through it.

todaywasawesome
todaywasawesome approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenting
fix: cache helm-index in Redis cluster
0fd1f27 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the fix-helm-index-cache branch from eabd5c2 to 0fd1f27 Compare August 15, 2024 08:37
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@69ef68f). Learn more about missing BASE report.
Report is 486 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #19530   +/-   ##
=========================================
  Coverage          ?   55.88%           
=========================================
  Files             ?      316           
  Lines             ?    43790           
  Branches          ?        0           
=========================================
  Hits              ?    24474           
  Misses            ?    16765           
  Partials          ?     2551

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jannfis
jannfis approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jenting
Copy link
Contributor Author

jenting commented Aug 21, 2024

@crenshaw-dev PTAL

@todaywasawesome
Merge branch 'master' into fix-helm-index-cache
406b895 
Signed-off-by: Dan Garfield <dan@codefresh.io>
@todaywasawesome
Update repository.go
d11e1c5 
Fix order

Signed-off-by: Dan Garfield <dan@codefresh.io>
todaywasawesome
todaywasawesome approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@todaywasawesome todaywasawesome enabled auto-merge (squash) August 21, 2024 15:14
@todaywasawesome todaywasawesome merged commit 80f2043 into argoproj:master Aug 21, 2024
27 of 28 checks passed
ashutosh16 pushed a commit that referenced this pull request Aug 23, 2024
@jenting @todaywasawesome
fix: cache helm-index in Redis cluster (#12314) (#19530)
455991e 
* fix: cache helm-index in Redis cluster

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>

* Update repository.go

Fix order

Signed-off-by: Dan Garfield <dan@codefresh.io>

---------

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: ashutosh16 <ashutosh_singh@intuit.com>
pasha-codefresh pushed a commit to pasha-codefresh/argo-cd that referenced this pull request Oct 9, 2024
@jenting @todaywasawesome @pasha-codefresh
fix: cache helm-index in Redis cluster (argoproj#12314) (argoproj#19530)
693a887 
* fix: cache helm-index in Redis cluster

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>

* Update repository.go

Fix order

Signed-off-by: Dan Garfield <dan@codefresh.io>

---------

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
@ericblackburn
Copy link
Contributor

I think we are hitting this. What release is this being placed in? Was this cherry picked to older versions?

@jenting jenting deleted the fix-helm-index-cache branch October 24, 2024 09:46
@ericblackburn
Copy link
Contributor

I see the change in the 2.13 branch but not the 2.12 release branch. It would be nice to cherry pick that into 2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianh814 christianh814 christianh814 approved these changes

@jannfis jannfis jannfis approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArgoCD start to DDoS related Helm Repository
6 participants
@jenting @ericblackburn @wanghong230 @todaywasawesome @jannfis @christianh814