Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix create app panel reappear after closed (issue #18904) #19717

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(ui): fix create app panel reappear after closed (issue #18904) #19717

merged 1 commit into from
Aug 29, 2024

Conversation

lsq645599166
Copy link
Contributor

Fixes #18904

This PR fixes an issue where close the create app panel immediately after typing, the panel will reappear.

Result

Before

2024-08-29.10.21.09.mov

After

2024-08-29.10.20.05.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@lsq645599166
fix(ui): fix create app panel reappear after closed
f06eed7 
Signed-off-by: henry.liu <henry.liu@daocloud.io>
@lsq645599166 lsq645599166 requested a review from a team as a code owner August 29, 2024 02:25
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 29, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 29, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

alexmt
alexmt approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit 1bbe17e into argoproj:master Aug 29, 2024
24 of 25 checks passed
eogns47 pushed a commit to eogns47/argo-cd that referenced this pull request Sep 2, 2024
@lsq645599166 @eogns47
fix(ui): fix create app panel reappear after closed (argoproj#19717)
f4de0d2 
Signed-off-by: henry.liu <henry.liu@daocloud.io>
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
@svghadi
Copy link
Contributor

svghadi commented Oct 15, 2024

Can we backport this? It is affecting v2.12.x.

@alexmt
Copy link
Collaborator

alexmt commented Oct 23, 2024

/cherry-pick release-2.12

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@lsq645599166
fix(ui): fix create app panel reappear after closed (#19717)
69a8fcc 
Signed-off-by: henry.liu <henry.liu@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 23, 2024
Merged
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Oct 23, 2024
@lsq645599166 @alexmt
fix(ui): fix create app panel reappear after closed (argoproj#19717)
38451df 
Signed-off-by: henry.liu <henry.liu@daocloud.io>
@alexmt alexmt mentioned this pull request Oct 23, 2024
Closed
@alexmt
Copy link
Collaborator

alexmt commented Oct 23, 2024

Agree, created cherry-pick PR #20508

alexmt pushed a commit that referenced this pull request Oct 23, 2024
@gcp-cherry-pick-bot @lsq645599166
fix(ui): fix create app panel reappear after closed (#19717) (#20507)
a41f868 
Signed-off-by: henry.liu <henry.liu@daocloud.io>
Co-authored-by: Henry Liu <henry.liu@daocloud.io>
This was referenced Oct 30, 2024
Closed
Closed
@lsq645599166 lsq645599166 mentioned this pull request Nov 27, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianh814 christianh814 christianh814 approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New App create panel 'can' reappear unexpectedly, immediately after it is closed
4 participants
@lsq645599166 @svghadi @alexmt @christianh814