Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get pull request target branch for Azure DevOps (#19869) #19871

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Get pull request target branch for Azure DevOps (#19869) #19871

merged 1 commit into from
Sep 17, 2024

Conversation

bonddim
Copy link
Contributor

@bonddim bonddim commented Sep 10, 2024

Closes #19869

@bonddim bonddim requested a review from a team as a code owner September 10, 2024 21:00
Copy link

bunnyshell bot commented Sep 10, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 10, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.87%. Comparing base (ca7a08e) to head (cb4fdf9).
Report is 474 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19871      +/-   ##
==========================================
+ Coverage   55.85%   55.87%   +0.02%     
==========================================
  Files         320      320              
  Lines       44323    44325       +2     
==========================================
+ Hits        24755    24765      +10     
+ Misses      17014    17006       -8     
  Partials     2554     2554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dmytro Bondar <git@bonddim.com>
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdsoumya gdsoumya merged commit dce41c4 into argoproj:master Sep 17, 2024
27 of 28 checks passed
@bonddim bonddim deleted the fix-19869-azure-devops-pr-target-branch-filter branch September 17, 2024 09:44
@bonddim
Copy link
Contributor Author

bonddim commented Nov 15, 2024

Hello @gdsoumya,
when to expect this fix in releases?

adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…argoproj#19871)

Signed-off-by: Dmytro Bondar <git@bonddim.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

targetBranchMatch filter does not work with pullRequest generator for Azure DevOps
2 participants