Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention information about where to set the ARGOCD_SYNC_WAVE_DELAY environment variable #19879

Merged
merged 4 commits into from
Sep 11, 2024
Merged

docs: mention information about where to set the ARGOCD_SYNC_WAVE_DELAY environment variable #19879

merged 4 commits into from
Sep 11, 2024

Conversation

nitishfy
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nitishfy
Update sync-waves.md
cfdfb4b 
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
@nitishfy nitishfy requested review from a team as code owners September 11, 2024 05:29
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

todaywasawesome
todaywasawesome requested changes Sep 11, 2024
View reviewed changes
docs/user-guide/sync-waves.md Outdated Show resolved Hide resolved
nitishfy and others added 2 commits September 11, 2024 20:54
@nitishfy @todaywasawesome
Update docs/user-guide/sync-waves.md
418e859 
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
@nitishfy
Merge branch 'master' into patch-1
d3a3c45
@alexmt alexmt enabled auto-merge (squash) September 11, 2024 18:56
@alexmt alexmt merged commit 5e55d1d into argoproj:master Sep 11, 2024
23 of 24 checks passed
@nitishfy nitishfy deleted the patch-1 branch October 25, 2024 09:55
@nitishfy nitishfy mentioned this pull request Oct 25, 2024
Closed
6 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@nitishfy @todaywasawesome @adriananeci
docs: mention information about where to set the `ARGOCD_SYNC_WAVE_DE…
5b8dc59 
…LAY` environment variable (argoproj#19879)

* Update sync-waves.md

Signed-off-by: Nitish Kumar <justnitish06@gmail.com>

* Update docs/user-guide/sync-waves.md

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>

---------

Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

@christianh814 christianh814 christianh814 approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nitishfy @alexmt @todaywasawesome @christianh814 @gdsoumya