Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sync windows): rename Sunday-Saturday (#19885) #19886

Merged
merged 3 commits into from
Sep 12, 2024
Merged

docs(sync windows): rename Sunday-Saturday (#19885) #19886

merged 3 commits into from
Sep 12, 2024

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx thiagowfx commented Sep 11, 2024 •
edited
Loading

Sunday-Saturday is ambiguous. It could mean:

  • sunday and saturday ONLY
  • from sunday to saturday (=every day of the week)

In order to disambiguate, we change the label to "Every Day".

Closes #19885

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thiagowfx thiagowfx requested a review from a team as a code owner September 11, 2024 09:23
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

todaywasawesome
todaywasawesome requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree, merge the suggestions.

ui/src/app/settings/components/project-sync-windows-edit/project-sync-windows-edit.tsx Outdated Show resolved Hide resolved
thiagowfx and others added 2 commits September 11, 2024 19:07
@thiagowfx
fix(sync windows): rename Sunday-Saturday
030929c 
Sunday-Saturday is ambiguous. It could mean:

- sunday and saturday ONLY
- from sunday to saturday (=every day of the week)

In order to disambiguate, we could change the label to one of the
following:

- Every Day of the Week
- Sunday to Saturday
- From Sunday to Saturday

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
@thiagowfx @todaywasawesome
Update ui/src/app/settings/components/project-sync-windows-edit/proje…
d158d4a 
…ct-sync-windows-edit.tsx

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
@thiagowfx thiagowfx force-pushed the thiagowfx/sunday-saturday branch from 1e9f5da to d158d4a Compare September 11, 2024 17:07
@todaywasawesome todaywasawesome enabled auto-merge (squash) September 11, 2024 22:53
@todaywasawesome todaywasawesome merged commit 022c4fd into argoproj:master Sep 12, 2024
23 of 24 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/sunday-saturday branch September 12, 2024 09:23
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@thiagowfx @todaywasawesome @adriananeci
docs(sync windows): rename Sunday-Saturday (argoproj#19885) (argoproj…
08dda3d 
…#19886)

* fix(sync windows): rename Sunday-Saturday

Sunday-Saturday is ambiguous. It could mean:

- sunday and saturday ONLY
- from sunday to saturday (=every day of the week)

In order to disambiguate, we could change the label to one of the
following:

- Every Day of the Week
- Sunday to Saturday
- From Sunday to Saturday

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>

* Update ui/src/app/settings/components/project-sync-windows-edit/project-sync-windows-edit.tsx

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>

---------

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX issue: Sync window "Sunday-Saturday" label is ambiguous
5 participants
@thiagowfx @wanghong230 @todaywasawesome @ishitasequeira @nitishfy