Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Application sets metrics documentation #19892

Merged
merged 6 commits into from
Sep 12, 2024
Merged

docs: Application sets metrics documentation #19892

merged 6 commits into from
Sep 12, 2024

Conversation

kostis-codefresh
Copy link
Member

Documentation for #19691

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@kostis-codefresh
docs: fixed wrong formatting of yaml
90f8650 
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
@kostis-codefresh
docs: metrics for application sets
82703a8 
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
@kostis-codefresh kostis-codefresh requested review from a team as code owners September 11, 2024 12:46
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@kostis-codefresh kostis-codefresh changed the title docs: Application sets docs docs: Application sets metrics documentation Sep 11, 2024
todaywasawesome
todaywasawesome requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small grammar suggestions for you to review @kostis-codefresh .

docs/operator-manual/metrics.md Outdated Show resolved Hide resolved
docs/operator-manual/metrics.md Outdated Show resolved Hide resolved
docs/operator-manual/metrics.md Outdated Show resolved Hide resolved
docs/operator-manual/metrics.md Outdated Show resolved Hide resolved
docs/operator-manual/metrics.md Outdated Show resolved Hide resolved
@kostis-codefresh @todaywasawesome
docs: applicationset metrics suggestions from code review
557713b 
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
wanghong230
wanghong230 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@wanghong230 wanghong230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting those things well.

@ishitasequeira ishitasequeira enabled auto-merge (squash) September 12, 2024 01:46
ishitasequeira
ishitasequeira reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@todaywasawesome are you good with the changes you requested?

alexmt
alexmt approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

alexmt and others added 2 commits September 11, 2024 20:20
@alexmt
Merge branch 'master' into application-sets-docs
0e3dc09
@kostis-codefresh @nitishfy
docs: minor formatting fix
a034f8f 
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
auto-merge was automatically disabled September 12, 2024 13:59

Head branch was pushed to by a user without write access

todaywasawesome
todaywasawesome approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@todaywasawesome todaywasawesome enabled auto-merge (squash) September 12, 2024 14:57
@todaywasawesome todaywasawesome merged commit 81de487 into argoproj:master Sep 12, 2024
21 of 23 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@kostis-codefresh @todaywasawesome
@alexmt @nitishfy @adriananeci
docs: Application sets metrics documentation (argoproj#19892)
4de4499 
* docs: fixed wrong formatting of yaml

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: metrics for application sets

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: applicationset metrics suggestions from code review

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: minor formatting fix

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

---------

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@nitishfy nitishfy nitishfy approved these changes

@reggie-k reggie-k reggie-k approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

@alexmt alexmt alexmt approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kostis-codefresh @alexmt @wanghong230 @todaywasawesome @reggie-k @ishitasequeira @nitishfy