Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): adding links for appset matrix example #19914

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix(docs): adding links for appset matrix example #19914

merged 3 commits into from
Sep 13, 2024

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Sep 12, 2024 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@rumstead
fix(docs): adding links for appset matrix example
f268824 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested review from a team as code owners September 12, 2024 14:38
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 12, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 12, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

todaywasawesome
todaywasawesome approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, surprised it didn't previously complain.

@todaywasawesome todaywasawesome merged commit cb6fbbf into argoproj:master Sep 13, 2024
23 of 24 checks passed
@rumstead rumstead deleted the fix/appset-matrix-example branch September 13, 2024 16:01
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@rumstead @adriananeci
fix(docs): adding links for appset matrix example (argoproj#19914)
1ebdfa9 
* fix(docs): adding links for appset matrix example

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>

* fix(docs): adding links for appset matrix example

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>

---------

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@christianh814 christianh814 christianh814 approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rumstead @todaywasawesome @christianh814 @nitishfy