Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): move graphs by dragging mouse in app resource tree view (#18025) #20009

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat(ui): move graphs by dragging mouse in app resource tree view (#18025) #20009

merged 1 commit into from
Sep 23, 2024

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Sep 19, 2024 •
edited
Loading

…gging the mouse

Fixes: #18025

Before

The application tree view can only be moved with the scroll axis or the scroll wheel.

Now

2024.09.19.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu
feat(ui): application resource tree support move graphs around by dra…
ab3ec6f 
…gging the mouse

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
@linghaoSu linghaoSu requested a review from a team as a code owner September 19, 2024 14:52
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@linghaoSu linghaoSu mentioned this pull request Sep 22, 2024
Closed
6 tasks
agaudreault
agaudreault approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code seems straightforward. Thanks for the video demo in the PR.

@agaudreault agaudreault changed the title feat(ui): application resource tree support move graphs around by dragging mouse feat(ui): move graphs by dragging mouse in app resource tree view (#18025) Sep 23, 2024
@agaudreault agaudreault merged commit fb825f7 into argoproj:master Sep 23, 2024
26 of 27 checks passed
@linghaoSu linghaoSu deleted the feat/drag-resource-graph branch September 23, 2024 14:02
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this pull request Sep 25, 2024
@linghaoSu @ratulbasak
feat(ui): move graphs by dragging mouse in app resource tree view (ar…
1bcaeec 
…goproj#18025) (argoproj#20009)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@linghaoSu @adriananeci
feat(ui): move graphs by dragging mouse in app resource tree view (ar…
7f78e51 
…goproj#18025) (argoproj#20009)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

@christianh814 christianh814 christianh814 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Move graphs around by dragging the mouse
3 participants
@linghaoSu @christianh814 @agaudreault